Skip to:
Content

Changeset 11579


Ignore:
Timestamp:
06/06/17 19:12:23 (7 months ago)
Author:
r-a-y
Message:

Uploader: Fix the "Select your File" upload button across all browsers.

This commit does a few things:

  • Properly fixes the "Select your File" button for Microsoft Edge. The changes to bp-plupload.js mirrors a similar change to wp-plupload.js (see #WP37039).
  • Rolls back some CSS hacks to attempt to fix the upload button in Microsoft Edge (see #7360). This caused the upload button to fail in iOS Safari.

Props r-a-y, benjlipchak, mrjarbenne, hnla.

Fixes #7416.

Location:
trunk/src/bp-core
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-core/css/avatar-rtl.css

    r11265 r11579  
    146146} 
    147147 
    148 .moxie-shim.moxie-shim-html5 { 
    149     top: 108px !important; 
    150     right: 40.1% !important; 
    151     width: 12em; 
    152 } 
    153  
    154148.moxie-shim.moxie-shim-html5 input { 
    155149    cursor: pointer; 
     
    175169} 
    176170 
    177 p.drag-drop-buttons input#bp-browse-button { 
    178     width: 12em; 
    179 } 
    180  
    181171.drag-drop .drag-drop-inside p { 
    182172    color: #767676; 
     
    188178.drag-drop-inside p.drag-drop-info { 
    189179    margin-top: 0; 
    190 } 
    191  
    192 @supports (-ms-accelerator:true) { 
    193     .drag-drop-inside p.drag-drop-info { 
    194         display: block; 
    195     } 
    196180} 
    197181 
  • trunk/src/bp-core/css/avatar.css

    r11265 r11579  
    146146} 
    147147 
    148 .moxie-shim.moxie-shim-html5 { 
    149     top: 108px !important; 
    150     left: 40.1% !important; 
    151     width: 12em; 
    152 } 
    153  
    154148.moxie-shim.moxie-shim-html5 input { 
    155149    cursor: pointer; 
     
    175169} 
    176170 
    177 p.drag-drop-buttons input#bp-browse-button { 
    178     width: 12em; 
    179 } 
    180  
    181171.drag-drop .drag-drop-inside p { 
    182172    color: #767676; 
     
    188178.drag-drop-inside p.drag-drop-info { 
    189179    margin-top: 0; 
    190 } 
    191  
    192 @supports (-ms-accelerator:true) { 
    193     .drag-drop-inside p.drag-drop-info { 
    194         display: block; 
    195     } 
    196180} 
    197181 
  • trunk/src/bp-core/js/bp-plupload.js

    r10207 r11579  
    9797 
    9898        } ); 
     99 
     100        // See https://core.trac.wordpress.org/ticket/37039 
     101        this.uploader.bind( 'postinit', function( up ) { 
     102            up.refresh(); 
     103        }); 
    99104 
    100105        // Init BuddyPress Uploader 
Note: See TracChangeset for help on using the changeset viewer.