Changeset 11579

Timestamp:

06/06/2017 07:12:23 PM (7 years ago)

Author:

r-a-y

Message:

Uploader: Fix the "Select your File" upload button across all browsers.

This commit does a few things:

• Properly fixes the "Select your File" button for Microsoft Edge. The changes to bp-plupload.js mirrors a similar change to wp-plupload.js (see ​#WP37039).
• Rolls back some CSS hacks to attempt to fix the upload button in Microsoft Edge (see #7360). This caused the upload button to fail in iOS Safari.

Props r-a-y, benjlipchak, mrjarbenne, hnla.

Fixes #7416.

Location:

trunk/src/bp-core

Files:

• css/avatar-rtl.css (modified) (3 diffs)
• css/avatar.css (modified) (3 diffs)
• js/bp-plupload.js (modified) (1 diff)

trunk/src/bp-core/css/avatar-rtl.css

@@ -146 +146 @@
 }
 
-.moxie-shim.moxie-shim-html5 {
-    top: 108px !important;
-    right: 40.1% !important;
-    width: 12em;
-}
-
 .moxie-shim.moxie-shim-html5 input {
     cursor: pointer;
@@ -175 +169 @@
 }
 
-p.drag-drop-buttons input#bp-browse-button {
-    width: 12em;
-}
-
 .drag-drop .drag-drop-inside p {
     color: #767676;
@@ -188 +178 @@
 .drag-drop-inside p.drag-drop-info {
     margin-top: 0;
-}
-
-@supports (-ms-accelerator:true) {
-    .drag-drop-inside p.drag-drop-info {
-        display: block;
-    }
 }
 

trunk/src/bp-core/css/avatar.css

@@ -146 +146 @@
 }
 
-.moxie-shim.moxie-shim-html5 {
-    top: 108px !important;
-    left: 40.1% !important;
-    width: 12em;
-}
-
 .moxie-shim.moxie-shim-html5 input {
     cursor: pointer;
@@ -175 +169 @@
 }
 
-p.drag-drop-buttons input#bp-browse-button {
-    width: 12em;
-}
-
 .drag-drop .drag-drop-inside p {
     color: #767676;
@@ -188 +178 @@
 .drag-drop-inside p.drag-drop-info {
     margin-top: 0;
-}
-
-@supports (-ms-accelerator:true) {
-    .drag-drop-inside p.drag-drop-info {
-        display: block;
-    }
 }
 

trunk/src/bp-core/js/bp-plupload.js

@@ -97 +97 @@
 
         } );
+
+        // See https://core.trac.wordpress.org/ticket/37039
+        this.uploader.bind( 'postinit', function( up ) {
+            up.refresh();
+        });
 
         // Init BuddyPress Uploader