Changeset 11577

Timestamp:

06/06/2017 05:46:13 PM (9 years ago)

Author:

dcavins

Message:

Messages: Show Compose and Notices screens only on "my profile."

When a site administrator visits another user’s messages, she should
not see the “Notices” or “Compose” navigation items or be able to visit
those screens. These should only be available when bp_is_my_profile()
is true.

See #7096.

File:

• trunk/src/bp-messages/classes/class-bp-messages-component.php (modified) (1 diff)

trunk/src/bp-messages/classes/class-bp-messages-component.php

@@ -205 +205 @@
                 );
 
-                $sub_nav[] = array(
-                        'name'            => __( 'Compose', 'buddypress' ),
-                        'slug'            => 'compose',
-                        'parent_url'      => $messages_link,
-                        'parent_slug'     => $slug,
-                        'screen_function' => 'messages_screen_compose',
-                        'position'        => 30,
-                        'user_has_access' => $access
-                );
-
-                if ( bp_current_user_can( 'bp_moderate' ) ) {
+                // Show certain screens only if the current user is the displayed user.
+                if ( bp_is_my_profile() ) {
+
+                        // Show "Compose" on the logged-in user's profile only.
                         $sub_nav[] = array(
-                                'name'            => __( 'Notices', 'buddypress' ),
-                                'slug'            => 'notices',
+                                'name'            => __( 'Compose', 'buddypress' ),
+                                'slug'            => 'compose',
                                 'parent_url'      => $messages_link,
                                 'parent_slug'     => $slug,
-                                'screen_function' => 'messages_screen_notices',
-                                'position'        => 90,
-                                'user_has_access' => true
-                        );
+                                'screen_function' => 'messages_screen_compose',
+                                'position'        => 30,
+                                'user_has_access' => $access
+                        );
+
+                        /*
+                         * Show "Notices" on the logged-in user's profile only
+                         * and then only if the user can create notices.
+                         */
+                        if ( bp_current_user_can( 'bp_moderate' ) ) {
+                                $sub_nav[] = array(
+                                        'name'            => __( 'Notices', 'buddypress' ),
+                                        'slug'            => 'notices',
+                                        'parent_url'      => $messages_link,
+                                        'parent_slug'     => $slug,
+                                        'screen_function' => 'messages_screen_notices',
+                                        'position'        => 90,
+                                        'user_has_access' => true
+                                );
+                        }
                 }