Skip to:
Content

Changeset 11576


Ignore:
Timestamp:
06/06/17 17:46:09 (8 months ago)
Author:
dcavins
Message:

Improve message recipient list string handling.

WordPress 2.5 introduced wp_sprintf_l() which is built to concatenate
arrays into natural language lists (and is meant to be translation
friendly). This commit uses that function to build the recipient list
text for single messages, like “Conversation between Three, Four, Two,
and you.”

Props Offereins.

See #7096.

Location:
trunk/src
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-messages/bp-messages-template.php

    r11449 r11576  
    16351635 
    16361636                $recipient_links[] = $recipient_link; 
     1637            } else { 
     1638                $recipient_links[] = __( 'you', 'buddypress' ); 
    16371639            } 
    16381640        } 
    16391641 
     1642        // Concatenate to natural language string. 
     1643        $recipient_links = wp_sprintf_l( '%l', $recipient_links ); 
     1644 
    16401645        /** 
    16411646         * Filters the HTML links to the profiles of recipients in the current thread. 
     
    16451650         * @param string $value Comma-separated list of recipient HTML links for current thread. 
    16461651         */ 
    1647         return apply_filters( 'bp_get_the_thread_recipients_list', implode( ', ', $recipient_links ) ); 
     1652        return apply_filters( 'bp_get_the_thread_recipients_list', $recipient_links ); 
    16481653    } 
    16491654 
  • trunk/src/bp-templates/bp-legacy/buddypress/members/single/messages/single.php

    r11003 r11576  
    3636                <?php else : ?> 
    3737 
    38                     <?php printf( __( 'Conversation between %s and you.', 'buddypress' ), bp_get_thread_recipients_list() ); ?> 
     38                    <?php printf( __( 'Conversation between %s.', 'buddypress' ), bp_get_thread_recipients_list() ); ?> 
    3939 
    4040                <?php endif; ?> 
Note: See TracChangeset for help on using the changeset viewer.