Changeset 11439 for branches/2.8

Timestamp:

02/22/2017 05:25:40 PM (8 years ago)

Author:

boonebgorges

Message:

Ensure "closed notice" array is an array before treating it like one.

This prevents fatal errors due to illegal string operations in PHP 7.1+.

Ports [11438] to the 2.8 branch.

See #7392.

Location:

branches/2.8

Files:

• . (modified) (1 prop)
• src/bp-templates/bp-legacy/buddypress-functions.php (modified) (1 diff)

branches/2.8/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1528 +1528 @@
 
     } else {
-        $user_id      = get_current_user_id();
-        $notice_ids   = bp_get_user_meta( $user_id, 'closed_notices', true );
+        $user_id    = get_current_user_id();
+        $notice_ids = bp_get_user_meta( $user_id, 'closed_notices', true );
+        if ( ! is_array( $notice_ids ) ) {
+            $notice_ids = array();
+        }
+
         $notice_ids[] = (int) $_POST['notice_id'];