Changeset 11409

Timestamp:

02/02/2017 09:08:02 AM (8 years ago)

Author:

offereins

Message:

XProfile: keep the field order value on save

Fixes a bug where the group's first field would be pushed to the bottom of
the field order stack on field save.

Fixes #7428

File:

• trunk/src/bp-xprofile/bp-xprofile-admin.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-admin.php

@@ -374 +374 @@
 
             $field->field_order = $wpdb->get_var( $wpdb->prepare( "SELECT field_order FROM {$bp->profile->table_name_fields} WHERE id = %d", $field_id ) );
-            if ( empty( $field->field_order ) || is_wp_error( $field->field_order ) ) {
+            if ( ! is_numeric( $field->field_order ) || is_wp_error( $field->field_order ) ) {
                 $field->field_order = (int) $wpdb->get_var( $wpdb->prepare( "SELECT max(field_order) FROM {$bp->profile->table_name_fields} WHERE group_id = %d", $group_id ) );
                 $field->field_order++;