Changeset 11381

Timestamp:

01/12/2017 01:18:16 AM (8 years ago)

Author:

mercime

Message:

Accessibility: Remove redundant title attributes from avatars and links.

See #7363.

Location:

trunk/src

Files:

• bp-blogs/bp-blogs-template.php (modified) (4 diffs)
• bp-core/classes/class-bp-core-login-widget.php (modified) (1 diff)
• bp-friends/bp-friends-widgets.php (modified) (1 diff)
• bp-friends/classes/class-bp-core-friends-widget.php (modified) (1 diff)
• bp-groups/bp-groups-notifications.php (modified) (1 diff)
• bp-groups/bp-groups-template.php (modified) (1 diff)
• bp-groups/bp-groups-widgets.php (modified) (1 diff)
• bp-groups/classes/class-bp-groups-widget.php (modified) (1 diff)
• bp-members/bp-members-widgets.php (modified) (1 diff)
• bp-members/classes/class-bp-core-members-widget.php (modified) (1 diff)

trunk/src/bp-blogs/bp-blogs-template.php

@@ -310 +310 @@
      *     @type string   $alt     Default: 'Profile picture of site author [user name]'.
      *     @type string   $class   Default: 'avatar'.
-     *     @type string   $title   Default: 'Profile picture of site author [user name]'.
      *     @type string   $type    Default: 'full'.
      *     @type int|bool $width   Default: false.
@@ -336 +335 @@
             'height'  => false,
             'class'   => 'avatar',
-            'title'   => sprintf( __( 'Profile picture of site author %s', 'buddypress' ), esc_attr( $author_displayname ) ),
             'id'      => false,
             'alt'     => sprintf( __( 'Profile picture of site author %s', 'buddypress' ), esc_attr( $author_displayname ) ),
@@ -389 +387 @@
                 }
 
-                $avatar = sprintf( '<img src="%1$s" class="%2$s" width="%3$s" height="%3$s" alt="%4$s" title="%4$s" />',
+                $avatar = sprintf( '<img src="%1$s" class="%2$s" width="%3$s" height="%3$s" alt="%4$s" />',
                     esc_url( $site_icon ),
                     esc_attr( "{$r['class']} avatar-{$size}" ),
@@ -402 +400 @@
             $avatar = bp_core_fetch_avatar( array(
                 'item_id'    => $blogs_template->blog->admin_user_id,
-                'title'      => $r['title'],
                 // 'avatar_dir' => 'blog-avatars',
                 // 'object'     => 'blog',

trunk/src/bp-core/classes/class-bp-core-login-widget.php

@@ -118 +118 @@
                 <?php if ( bp_get_signup_allowed() ) : ?>
 
-                    <span class="bp-login-widget-register-link"><a href="<?php echo esc_url( bp_get_signup_page() ); ?>" title="<?php esc_attr_e( 'Register for a new account', 'buddypress' ); ?>"><?php _e( 'Register', 'buddypress' ); ?></a></span>
+                    <span class="bp-login-widget-register-link"><a href="<?php echo esc_url( bp_get_signup_page() ); ?>"><?php _e( 'Register', 'buddypress' ); ?></a></span>
 
                 <?php endif; ?>

trunk/src/bp-friends/bp-friends-widgets.php

@@ -73 +73 @@
 
                 <div class="item">
-                    <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>" title="<?php bp_member_name(); ?>"><?php bp_member_name(); ?></a></div>
+                    <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>"><?php bp_member_name(); ?></a></div>
                     <?php if ( 'active' == $type ) : ?>
                         <div class="item-meta"><span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_member_last_active( array( 'relative' => false ) ) ); ?>"><?php bp_member_last_active(); ?></span></div>

trunk/src/bp-friends/classes/class-bp-core-friends-widget.php

@@ -116 +116 @@
 
                         <div class="item">
-                            <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>" title="<?php bp_member_name(); ?>"><?php bp_member_name(); ?></a></div>
+                            <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>"><?php bp_member_name(); ?></a></div>
                             <div class="item-meta">
                                 <?php if ( 'newest' == $instance['friend_default'] ) : ?>

trunk/src/bp-groups/bp-groups-notifications.php

@@ -431 +431 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . sprintf( __( '%s requests group membership', 'buddypress' ), $user_fullname ) . '">' . $text . '</a>', $group_link, $user_fullname, $group->name, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $group_link, $user_fullname, $group->name, $text, $notification_link );
                 } else {
 

trunk/src/bp-groups/bp-groups-template.php

@@ -796 +796 @@
         $avatar = bp_core_fetch_avatar( array(
             'item_id'    => $groups_template->group->id,
-            'title'      => $groups_template->group->name,
             'avatar_dir' => 'group-avatars',
             'object'     => 'group',

trunk/src/bp-groups/bp-groups-widgets.php

@@ -63 +63 @@
 
                 <div class="item">
-                    <div class="item-title"><a href="<?php bp_group_permalink() ?>" title="<?php bp_group_name() ?>"><?php bp_group_name() ?></a></div>
+                    <div class="item-title"><a href="<?php bp_group_permalink() ?>"><?php bp_group_name() ?></a></div>
                     <div class="item-meta">
                         <?php if ( 'newest-groups' === $_POST['filter'] ) : ?>

trunk/src/bp-groups/classes/class-bp-groups-widget.php

@@ -136 +136 @@
 
                         <div class="item">
-                            <div class="item-title"><a href="<?php bp_group_permalink() ?>" title="<?php bp_group_name() ?>"><?php bp_group_name() ?></a></div>
+                            <div class="item-title"><a href="<?php bp_group_permalink() ?>"><?php bp_group_name() ?></a></div>
                             <div class="item-meta">
                                 <span class="activity">

trunk/src/bp-members/bp-members-widgets.php

@@ -84 +84 @@
 
                 <div class="item">
-                    <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>" title="<?php bp_member_name(); ?>"><?php bp_member_name(); ?></a></div>
+                    <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>"><?php bp_member_name(); ?></a></div>
                     <?php if ( 'active' === $type ) : ?>
                         <div class="item-meta"><span class="activity"><?php bp_member_last_active(); ?></span></div>

trunk/src/bp-members/classes/class-bp-core-members-widget.php

@@ -131 +131 @@
 
                         <div class="item">
-                            <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>" title="<?php bp_member_name(); ?>"><?php bp_member_name(); ?></a></div>
+                            <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>"><?php bp_member_name(); ?></a></div>
                             <div class="item-meta">
                                 <?php if ( 'newest' == $settings['member_default'] ) : ?>