Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
01/06/2017 03:56:09 AM (9 years ago)
Author:
boonebgorges
Message:

Lazy-load user property in BP_Groups_Member.

The user property is a BP_Core_User object, but is rarely
used by BP core. Only loading it when needed can save database
queries in certain cases, such as when a user is being promoted
or demoted within a group.

Props r-a-y.
Fixes #7382.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/groups/class-bp-groups-member.php

    r11091 r11378  
    13011301        $this->assertEqualSets( array( $m0, $m1 ), wp_list_pluck( $found, 'id' ) );
    13021302    }
     1303
     1304    /**
     1305     * @ticket BP7382
     1306     */
     1307    public function test_user_property_should_be_accessible() {
     1308        $user = $this->factory->user->create();
     1309        $group = $this->factory->group->create();
     1310
     1311        $this->add_user_to_group( $user, $group );
     1312
     1313        $membership = new BP_Groups_Member( $user, $group );
     1314
     1315        $user_obj = $membership->user;
     1316
     1317        $this->assertInstanceOf( 'BP_Core_User', $user_obj );
     1318        $this->assertEquals( $user, $user_obj->id );
     1319    }
    13031320}
Note: See TracChangeset for help on using the changeset viewer.