Changeset 11312 for trunk/src/bp-activity/classes/class-bp-activity-activity.php

Timestamp:

12/20/2016 02:54:45 AM (10 years ago)

Author:

boonebgorges

Message:

Activity: After populate(), activity items with a bad ID should have id = 0.

Props jdgrimes.
Fixes #7394.

File:

• trunk/src/bp-activity/classes/class-bp-activity-activity.php (modified) (1 diff)

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -186 +186 @@
                 }
 
-                if ( ! empty( $row ) ) {
-                        $this->id                = (int) $row->id;
-                        $this->item_id           = (int) $row->item_id;
-                        $this->secondary_item_id = (int) $row->secondary_item_id;
-                        $this->user_id           = (int) $row->user_id;
-                        $this->primary_link      = $row->primary_link;
-                        $this->component         = $row->component;
-                        $this->type              = $row->type;
-                        $this->action            = $row->action;
-                        $this->content           = $row->content;
-                        $this->date_recorded     = $row->date_recorded;
-                        $this->hide_sitewide     = (int) $row->hide_sitewide;
-                        $this->mptt_left         = (int) $row->mptt_left;
-                        $this->mptt_right        = (int) $row->mptt_right;
-                        $this->is_spam           = (int) $row->is_spam;
-                }
+                if ( empty( $row ) ) {
+                        $this->id = 0;
+                        return;
+                }
+
+                $this->id                = (int) $row->id;
+                $this->item_id           = (int) $row->item_id;
+                $this->secondary_item_id = (int) $row->secondary_item_id;
+                $this->user_id           = (int) $row->user_id;
+                $this->primary_link      = $row->primary_link;
+                $this->component         = $row->component;
+                $this->type              = $row->type;
+                $this->action            = $row->action;
+                $this->content           = $row->content;
+                $this->date_recorded     = $row->date_recorded;
+                $this->hide_sitewide     = (int) $row->hide_sitewide;
+                $this->mptt_left         = (int) $row->mptt_left;
+                $this->mptt_right        = (int) $row->mptt_right;
+                $this->is_spam           = (int) $row->is_spam;
 
                 // Generate dynamic 'action' when possible.