Changeset 11258 for trunk/src/bp-xprofile/bp-xprofile-template.php

Timestamp:

11/29/2016 09:58:29 AM (8 years ago)

Author:

hnla

Message:

Update 'bp_profile_get_settings_visibity_select()' function args

• Add new args to support elements before & after for the form controls.
• Add class attr for form label & notoggle elements.
• Add arg for notoggle tags element.

Update allows developers to manage markup output directly from template, providing an additional set of elements to wrap form controls to allow for styling hooks to change select styling, changing of classes for label & notoggle elements to suit & changing the notoggle tags element if required.

Fixes #7364

File:

• trunk/src/bp-xprofile/bp-xprofile-template.php (modified) (4 diffs)

trunk/src/bp-xprofile/bp-xprofile-template.php

@@ -1359 +1359 @@
      *    @type int    $field_id ID of the field to render.
      *    @type string $before   Markup to render before the field.
+     *    @type string $before_controls  markup before form controls.
      *    @type string $after    Markup to render after the field.
+     *    @type string $after_controls Markup after the form controls.
      *    @type string $class    Class to apply to the field markup.
+     *    @type string $label_class Class to apply for the label element.
+     *    @type string $notoggle_tag Markup element to use for notoggle tag.
+     *    @type string $notoggle_class Class to apply to the notoggle element.
      * }
      * @return string $retval
@@ -1368 +1373 @@
         // Parse optional arguments.
         $r = bp_parse_args( $args, array(
-            'field_id' => bp_get_the_profile_field_id(),
-            'before'   => '',
-            'after'    => '',
-            'class'    => 'bp-xprofile-visibility'
+            'field_id'         => bp_get_the_profile_field_id(),
+            'before'           => '',
+            'before_controls'  => '',
+            'after'            => '',
+            'after_controls'   => '',
+            'class'            => 'bp-xprofile-visibility',
+            'label_class'      => 'bp-screen-reader-text',
+            'notoggle_tag'     => 'span',
+            'notoggle_class'   => 'field-visibility-settings-notoggle',
         ), 'xprofile_settings_visibility_select' );
 
@@ -1388 +1398 @@
             <?php if ( bp_current_user_can( 'bp_xprofile_change_field_visibility' ) ) : ?>
 
-                <label for="<?php echo esc_attr( 'field_' . $r['field_id'] ) ; ?>_visibility" class="bp-screen-reader-text"><?php
+            <?php echo $r['before_controls']; ?>
+
+                <label for="<?php echo esc_attr( 'field_' . $r['field_id'] ) ; ?>_visibility" class="<?php echo esc_attr( $r['label_class'] ); ?>"><?php
                     /* translators: accessibility text */
                     _e( 'Select visibility', 'buddypress' );
@@ -1402 +1414 @@
                 </select>
 
+            <?php echo $r['after_controls']; ?>
+
             <?php else : ?>
 
-                <span class="field-visibility-settings-notoggle"><?php bp_the_profile_field_visibility_level_label(); ?></span>
+                <<?php echo esc_html( $r['notoggle_tag'] ); ?> class="<?php echo esc_attr( $r['notoggle_class'] ); ?>"><?php bp_the_profile_field_visibility_level_label(); ?></<?php echo esc_html( $r['notoggle_tag'] ); ?>>
 
             <?php endif;