Changeset 11246 for trunk/src/bp-xprofile/classes/class-bp-xprofile-user-admin.php

Timestamp:

11/24/2016 06:42:49 PM (9 years ago)

Author:

mercime

Message:

Accessibility: Use <button> elements in Profile visibility settings.

Replace empty links <a href="#"> with semantic <button> elements for
semantics and accessibility.

Fixes #7358.

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-user-admin.php (modified) (2 diffs)

trunk/src/bp-xprofile/classes/class-bp-xprofile-user-admin.php

@@ -398 +398 @@
                         <?php if ( $can_change_visibility ) : ?>
 
-                            <a href="#" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></a>
+                            <button type="button" class="button visibility-toggle-link"><?php esc_html_e( 'Change', 'buddypress' ); ?></button>
 
                         <?php endif; ?>
@@ -412 +412 @@
 
                             </fieldset>
-                            <a class="button field-visibility-settings-close" href="#"><?php esc_html_e( 'Close', 'buddypress' ); ?></a>
+                            <button type="button" class="button field-visibility-settings-close"><?php esc_html_e( 'Close', 'buddypress' ); ?></button>
                         </div>