Changeset 11223

Timestamp:

11/03/2016 08:47:31 AM (8 years ago)

Author:

djpaul

Message:

Core: remove wp->init() PHP notice from bp_setup_current_user() due to load order changes in WordPress 4.7.

In WordPress 4.7, the get_user_locale() function will always invoke the current user object before the init hook has fired.
This should cause no other regression for BuddyPress as we don't use primitive roles yet.

Fixes #7305 for the 2.7 branch, props johnjamesjacoby

File:

• branches/2.7/src/bp-core/bp-core-dependency.php (modified) (2 diffs)

branches/2.7/src/bp-core/bp-core-dependency.php

@@ -208 +208 @@
  * Set up the currently logged-in user.
  *
- * We white-list the WordPress Customizer which purposely loads the user early.
- * If the current user is being setup before the "init" action has fired,
- * strange (and difficult to debug) role/capability issues will occur.
- *
  * @since 1.7.0
  *
@@ -218 +214 @@
  */
 function bp_setup_current_user() {
-    $skip_warning = (
-        ( isset( $_REQUEST['wp_customize'] ) && 'on' === $_REQUEST['wp_customize'] ) ||
-        ( is_admin() && 'customize.php' === basename( $_SERVER['PHP_SELF'] ) )
-    );
-
-    if ( ! $skip_warning && ! did_action( 'after_setup_theme' ) ) {
-        $e = new Exception;
-        $trace = $e->getTraceAsString();
-
-        _doing_it_wrong( __FUNCTION__, __( 'The current user is being initialized without using $wp->init().', 'buddypress' ) . "\n===\nTrace:\n" . substr( $trace, strpos( $trace, '#6' ) ) . "\n===\n", '1.7' );
-    }
 
     /**