Changeset 11210 for trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-datebox.php

Timestamp:

10/25/2016 09:15:19 PM (8 years ago)

Author:

djpaul

Message:

xprofile: fix regression being unable to select year in date field type.

Pre-2.7 date fields do not have all of the new field meta properties set, and the requested metas were returned as an empty string, not a boolean false. The type strictness of the check changed in this commit caused the value(s) of the year field to be set to an empty array, instead of picking up the range of dates from the defaults.

This was probably caused by some misleading PHPDoc for bp_xprofile_get_meta, which we're going to look into seperately.

Fixes #7300

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-datebox.php (modified) (1 diff)

trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-datebox.php

@@ -349 +349 @@
         foreach ( $defaults as $key => $value ) {
             $saved = bp_xprofile_get_meta( $field_id, 'field', $key, true );
-            if ( false !== $saved ) {
+
+            if ( $saved ) {
                 $settings[ $key ] = $saved;
             } else {