Changeset 11177

Timestamp:

10/06/2016 08:18:49 AM (7 years ago)

Author:

r-a-y

Message:

bp-legacy: Do not show trailing dash for empty group type description.

Also adds a translator note and HTML-escapes the group type description
string.

See #7210.

File:

• trunk/src/bp-templates/bp-legacy/buddypress/groups/create.php (modified) (1 diff)

trunk/src/bp-templates/bp-legacy/buddypress/groups/create.php

@@ -158 +158 @@
                                 <label for="<?php printf( 'group-type-%s', $type->name ); ?>"><input type="checkbox" name="group-types[]" id="<?php printf( 'group-type-%s', $type->name ); ?>" value="<?php echo esc_attr( $type->name ); ?>" /> <?php echo esc_html( $type->labels['name'] ); ?>
                                     <?php
-                                        if ( isset( $type->description ) ) {
-                                            printf( __( '&ndash; %s', 'buddypress' ), '<span class="bp-group-type-desc">' . $type->description . '</span>' );
+                                        if ( ! empty( $type->description ) ) {
+                                            /* translators: Group type description shown when creating a group. */
+                                            printf( __( '&ndash; %s', 'buddypress' ), '<span class="bp-group-type-desc">' . esc_html( $type->description ) . '</span>' );
                                         }
                                     ?>