Changeset 11125

Timestamp:

09/20/2016 09:58:13 PM (8 years ago)

Author:

dcavins

Message:

Friends tests: Set date_created to ensure reliable ordering.

Some of the tests for friendship functionality use assertEquals(),
which requires that the elements of arrays be in the same order and
each value be equal. In some cases, the order of the elements returned
by functions like friends_get_friendship_request_user_ids() was
unreliable, probably because phpunit was working quickly enough that
the date_created was indeterminate. This change set manually sets the
earlier friendship back in time so that the return values can be
checked reliably.

See #6978.

File:

• trunk/tests/phpunit/testcases/friends/functions.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/friends/functions.php

@@ -28 +28 @@
         friends_add_friend( $u3, $u1 );
 
+        // Set the time of the earlier friendship for reliable ordering of the results.
+        $fid = friends_get_friendship_id( $u2, $u1 );
+        $friendship = new BP_Friends_Friendship( $fid, false, false );
+        $friendship->date_created = date( 'Y-m-d H:i:s', time() - 60 );
+        $friendship->save();
+
         // get request count for user 1 and assert
         $requests = friends_get_friendship_request_user_ids( $u1 );
-        $this->assertEquals( array( $u2, $u3 ), $requests );
+        $this->assertEquals( array( $u3, $u2 ), $requests );
 
         // accept friendship
@@ -55 +61 @@
         // request friendship
         friends_add_friend( $u2, $u1 );
+        // Set the time of the earlier friendship for reliable ordering of the results.
+        $fid = friends_get_friendship_id( $u2, $u1 );
+        $friendship = new BP_Friends_Friendship( $fid, false, false );
+        $friendship->date_created = date( 'Y-m-d H:i:s', time() - 60 );
+        $friendship->save();
 
         // get request count for user 1 and assert
@@ -65 +76 @@
         // refetch request count for user 1 and assert
         $requests = friends_get_friendship_request_user_ids( $u1 );
-        $this->assertEquals( array( $u2, $u3 ), $requests );
+        $this->assertEquals( array( $u3, $u2 ), $requests );
     }