Changeset 11124 for trunk/tests/phpunit/testcases/friends/functions.php

Timestamp:

09/20/2016 02:42:15 PM (9 years ago)

Author:

dcavins

Message:

Use new function BP_Friends_Friendships::get_friendships().

Take advantage of the caching introduced
in BP_Friends_Friendships::get_friendships()
by using get_friendships() as the underlying function in
get_friend_user_ids(), get_friendship_id(), total_friend_count(),
check_is_friend(),
and delete_all_for_user().

Props dcavins, boonebgorges.

Fixes #6978.

File:

• trunk/tests/phpunit/testcases/friends/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/friends/functions.php

@@ -268 +268 @@
         return $value;
     }
+
+    /**
+     * @group friendship_caching
+     */
+    public function test_friends_check_friendship_should_hit_user_cache() {
+        global $wpdb;
+        $now = time();
+        $u1 = $this->factory->user->create( array(
+            'last_activity' => date( 'Y-m-d H:i:s', $now ),
+        ) );
+        $u2 = $this->factory->user->create( array(
+            'last_activity' => date( 'Y-m-d H:i:s', $now - 100 ),
+        ) );
+        $u3 = $this->factory->user->create( array(
+            'last_activity' => date( 'Y-m-d H:i:s', $now - 200 ),
+        ) );
+
+        friends_add_friend( $u1, $u2, true );
+        friends_add_friend( $u1, $u3, false );
+
+        friends_check_friendship_status( $u1, $u2 );
+        $first_query_count = $wpdb->num_queries;
+
+        friends_check_friendship_status( $u1, $u3 );
+
+        $this->assertEquals( $first_query_count, $wpdb->num_queries );
+    }
+
+    /**
+     * @group friendship_caching
+     */
+    public function test_friends_check_friendship_should_hit_friendship_object_cache() {
+        global $wpdb;
+        $now = time();
+        $u1 = $this->factory->user->create( array(
+            'last_activity' => date( 'Y-m-d H:i:s', $now ),
+        ) );
+        $u2 = $this->factory->user->create( array(
+            'last_activity' => date( 'Y-m-d H:i:s', $now - 100 ),
+        ) );
+
+        friends_add_friend( $u1, $u2, true );
+
+        friends_check_friendship_status( $u1, $u2 );
+        $first_query_count = $wpdb->num_queries;
+
+        /*
+         * We expect this to generate one query to find $u2's friendships,
+         * but the friendship object itself should come from cache.
+         */
+        friends_check_friendship_status( $u2, $u1 );
+
+        $this->assertEquals( $first_query_count + 1, $wpdb->num_queries );
+    }
 }