Changeset 11124 for trunk/src/bp-friends/classes/class-bp-friends-friendship.php

Timestamp:

09/20/2016 02:42:15 PM (9 years ago)

Author:

dcavins

Message:

Use new function BP_Friends_Friendships::get_friendships().

Take advantage of the caching introduced
in BP_Friends_Friendships::get_friendships()
by using get_friendships() as the underlying function in
get_friend_user_ids(), get_friendship_id(), total_friend_count(),
check_is_friend(),
and delete_all_for_user().

Props dcavins, boonebgorges.

Fixes #6978.

File:

• trunk/src/bp-friends/classes/class-bp-friends-friendship.php (modified) (8 diffs)

trunk/src/bp-friends/classes/class-bp-friends-friendship.php

@@ -390 +390 @@
         global $wpdb;
 
-        if ( !empty( $friend_requests_only ) ) {
-            $oc_sql = 'AND is_confirmed = 0';
-            $friend_sql = $wpdb->prepare( " WHERE friend_user_id = %d", $user_id );
+        if ( ! empty( $friend_requests_only ) ) {
+            $args = array(
+                'is_confirmed' => 0,
+                'friend_user_id' => $user_id
+            );
         } else {
-            $oc_sql = 'AND is_confirmed = 1';
-            $friend_sql = $wpdb->prepare( " WHERE (initiator_user_id = %d OR friend_user_id = %d)", $user_id, $user_id );
-        }
-
-        $bp = buddypress();
-        $friends = $wpdb->get_results( "SELECT friend_user_id, initiator_user_id FROM {$bp->friends->table_name} {$friend_sql} {$oc_sql} ORDER BY date_created DESC" );
+            $args = array(
+                'is_confirmed' => 1,
+            );
+        }
+
+        $friendships = self::get_friendships( $user_id, $args );
+
         $fids = array();
-
-        for ( $i = 0, $count = count( $friends ); $i < $count; ++$i ) {
-            if ( !empty( $assoc_arr ) ) {
-                $fids[] = array( 'user_id' => ( $friends[$i]->friend_user_id == $user_id ) ? $friends[$i]->initiator_user_id : $friends[$i]->friend_user_id );
+        foreach ( $friendships as $friendship ) {
+            if ( ! empty( $assoc_arr ) ) {
+                $fids[] = array( 'user_id' => ( $friendship->friend_user_id == $user_id ) ? $friendship->initiator_user_id : $friendship->friend_user_id );
             } else {
-                $fids[] = ( $friends[$i]->friend_user_id == $user_id ) ? $friends[$i]->initiator_user_id : $friends[$i]->friend_user_id;
+                $fids[] = ( $friendship->friend_user_id == $user_id ) ? $friendship->initiator_user_id : $friendship->friend_user_id;
             }
         }
@@ -423 +425 @@
      */
     public static function get_friendship_id( $user_id, $friend_id ) {
-        global $wpdb;
-
-        $bp = buddypress();
-
-        $query = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$bp->friends->table_name} WHERE ( initiator_user_id = %d AND friend_user_id = %d ) OR ( initiator_user_id = %d AND friend_user_id = %d ) AND is_confirmed = 1", $user_id, $friend_id, $friend_id, $user_id ) );
-
-        return is_numeric( $query ) ? (int) $query : $query;
+        $friendship_id = null;
+
+        // Can't friend yourself.
+        if ( $user_id == $friend_id ) {
+            return $friendship_id;
+        }
+
+        /*
+         * Find friendships where the possible_friend_userid is the
+         * initiator or friend.
+         */
+        $args = array(
+            'initiator_user_id' => $friend_id,
+            'friend_user_id'    => $friend_id
+        );
+        $result = self::get_friendships( $user_id, $args, 'OR' );
+        if ( $result ) {
+            $friendship_id = current( $result )->id;
+        }
+        return $friendship_id;
     }
 
@@ -445 +460 @@
 
         if ( false === $friend_requests ) {
-            global $wpdb;
-
-            $bp = buddypress();
-
-            $friend_requests = $wpdb->get_col( $wpdb->prepare( "SELECT initiator_user_id FROM {$bp->friends->table_name} WHERE friend_user_id = %d AND is_confirmed = 0", $user_id ) );
+            $friend_requests = self::get_friend_user_ids( $user_id, true );
 
             wp_cache_set( $user_id, $friend_requests, 'bp_friends_requests' );
@@ -475 +486 @@
         global $wpdb;
 
-        if ( empty( $user_id ) )
+        if ( empty( $user_id ) ) {
             $user_id = ( bp_displayed_user_id() ) ? bp_displayed_user_id() : bp_loggedin_user_id();
-
-        $bp = buddypress();
+        }
 
         /*
@@ -485 +495 @@
          */
 
-        $count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(id) FROM {$bp->friends->table_name} WHERE (initiator_user_id = %d OR friend_user_id = %d) AND is_confirmed = 1", $user_id, $user_id ) );
+        $args = array(
+            'is_confirmed' => 1,
+        );
+        $friendships = self::get_friendships( $user_id, $args );
+        $count       = count( $friendships );
 
         // Do not update meta if user has never had friends.
-        if ( empty( $count ) && !bp_get_user_meta( $user_id, 'total_friend_count', true ) )
+        if ( ! $count && ! bp_get_user_meta( $user_id, 'total_friend_count', true ) ) {
             return 0;
+        }
 
         bp_update_user_meta( $user_id, 'total_friend_count', (int) $count );
@@ -584 +599 @@
         }
 
-        $bp = buddypress();
-
-        $result = $wpdb->get_results( $wpdb->prepare( "SELECT id, initiator_user_id, is_confirmed FROM {$bp->friends->table_name} WHERE (initiator_user_id = %d AND friend_user_id = %d) OR (initiator_user_id = %d AND friend_user_id = %d)", $initiator_userid, $possible_friend_userid, $possible_friend_userid, $initiator_userid ) );
-
-        if ( ! empty( $result ) ) {
-            if ( 0 == (int) $result[0]->is_confirmed ) {
-                $status = $initiator_userid == $result[0]->initiator_user_id ? 'pending' : 'awaiting_response';
+        // Can't friend yourself.
+        if ( $initiator_userid == $possible_friend_userid ) {
+            return 'not_friends';
+        }
+
+        /*
+         * Find friendships where the possible_friend_userid is the
+         * initiator or friend.
+         */
+        $args = array(
+            'initiator_user_id' => $possible_friend_userid,
+            'friend_user_id'    => $possible_friend_userid
+        );
+        $result = self::get_friendships( $initiator_userid, $args, 'OR' );
+
+        if ( $result ) {
+            $friendship = current( $result );
+            if ( ! $friendship->is_confirmed ) {
+                $status = $initiator_userid == $friendship->initiator_user_id ? 'pending' : 'awaiting_response';
             } else {
                 $status = 'is_friend';
@@ -919 +946 @@
         $bp = buddypress();
 
-        // Get friends of $user_id.
-        $friend_ids = BP_Friends_Friendship::get_friend_user_ids( $user_id );
-
-        // Delete all friendships related to $user_id.
-        $wpdb->query( $wpdb->prepare( "DELETE FROM {$bp->friends->table_name} WHERE friend_user_id = %d OR initiator_user_id = %d", $user_id, $user_id ) );
+        // Get all friendships, of any status, for the user.
+        $friendships    = self::get_friendships( $user_id );
+        $friend_ids     = array();
+        $friendship_ids = array();
+        foreach ( $friendships as $friendship ) {
+            $friendship_ids[] = $friendship->id;
+            if ( $friendship->is_confirmed ) {
+                $friend_ids[] = ( $friendship->friend_user_id == $user_id ) ? $friendship->initiator_user_id : $friendship->friend_user_id;
+            }
+        }
+
+        // Delete the friendships from the database.
+        if ( $friendship_ids ) {
+            $friendship_ids_sql = implode( ',', wp_parse_id_list( $friendship_ids ) );
+            $wpdb->query( "DELETE FROM {$bp->friends->table_name} WHERE id IN ({$friendship_ids_sql})" );
+        }
 
         // Delete friend request notifications for members who have a
@@ -931 +969 @@
         }
 
-        // Loop through friend_ids and update their counts.
+        // Clean up the friendships cache.
+        foreach ( $friendship_ids as $friendship_id ) {
+            wp_cache_delete( $friendship_id, 'bp_friends_friendships' );
+        }
+
+        // Loop through friend_ids to scrub user caches and update total count metas.
         foreach ( (array) $friend_ids as $friend_id ) {
+            // Delete cached friendships.
+            wp_cache_delete( $friend_id, 'bp_friends_friendships_for_user' );
             BP_Friends_Friendship::total_friend_count( $friend_id );
         }
+
+        // Delete cached friendships.
+        wp_cache_delete( $user_id, 'bp_friends_friendships_for_user' );
     }
 }