Changeset 11122 for trunk/src/bp-friends/classes/class-bp-friends-friendship.php

Timestamp:

09/20/2016 02:42:04 PM (9 years ago)

Author:

dcavins

Message:

Add bp_friends_friendships cache group.

Add friendship caching by the ID of the friendship.
Check the cache before querying for friendship
details in BP_Friends_Friendship::populate.

Update get_user_ids_for_friendship() to create
a new friendship object so it could possibly use
the cached object.

Props dcavins, boonebgorges.

See #6978.

File:

• trunk/src/bp-friends/classes/class-bp-friends-friendship.php (modified) (2 diffs)

trunk/src/bp-friends/classes/class-bp-friends-friendship.php

@@ -123 +123 @@
         $bp = buddypress();
 
-        if ( $friendship = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->friends->table_name} WHERE id = %d", $this->id ) ) ) {
-            $this->initiator_user_id = (int) $friendship->initiator_user_id;
-            $this->friend_user_id    = (int) $friendship->friend_user_id;
-            $this->is_confirmed      = (int) $friendship->is_confirmed;
-            $this->is_limited        = (int) $friendship->is_limited;
-            $this->date_created      = $friendship->date_created;
-        }
-
-        if ( !empty( $this->populate_friend_details ) ) {
+        // Check cache for friendship data.
+        $friendship = wp_cache_get( $this->id, 'bp_friends_friendships' );
+
+        // Cache missed, so query the DB.
+        if ( false === $friendship ) {
+            $friendship = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$bp->friends->table_name} WHERE id = %d", $this->id ) );
+
+            wp_cache_set( $this->id, $friendship, 'bp_friends_friendships' );
+        }
+
+        // No friendship found so set the ID and bail.
+        if ( empty( $friendship ) || is_wp_error( $friendship ) ) {
+            $this->id = 0;
+            return;
+        }
+
+        $this->initiator_user_id = (int) $friendship->initiator_user_id;
+        $this->friend_user_id    = (int) $friendship->friend_user_id;
+        $this->is_confirmed      = (int) $friendship->is_confirmed;
+        $this->is_limited        = (int) $friendship->is_limited;
+        $this->date_created      = $friendship->date_created;
+
+        if ( ! empty( $this->populate_friend_details ) ) {
             if ( $this->friend_user_id == bp_displayed_user_id() ) {
                 $this->friend = new BP_Core_User( $this->initiator_user_id );
@@ -708 +722 @@
      */
     public static function get_user_ids_for_friendship( $friendship_id ) {
-        global $wpdb;
-
-        $bp = buddypress();
-
-        return $wpdb->get_row( $wpdb->prepare( "SELECT friend_user_id, initiator_user_id FROM {$bp->friends->table_name} WHERE id = %d", $friendship_id ) );
+
+        $friendship = new BP_Friends_Friendship( $friendship_id, false, false );
+
+        if ( empty( $friendship->id ) ) {
+            return null;
+        }
+
+        $retval = new StdClass;
+        $retval->friend_user_id = $friendship->friend_user_id;
+        $retval->initiator_user_id = $friendship->initiator_user_id;
+
+        return $retval;
     }