Changeset 11100 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

09/14/2016 01:34:44 AM (9 years ago)

Author:

boonebgorges

Message:

Groups: Eliminate the populate_extras option from the bp_has_groups() stack.

Fun fact: Now that all these values are cached and lazy-loaded, the
parameter no longer does anything. Begone!

See #5451.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (3 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -882 +882 @@
      *     @type array|string $parent_id          Optional. Array or comma-separated list of group IDs. Results
      *                                            will be limited to children of the specified groups. Default: null.
-     *     @type bool         $populate_extras    Whether to fetch additional information
-     *                                            (such as member count) about groups. Default: true.
      *     @type array|string $exclude            Optional. Array or comma-separated list of group IDs.
      *                                            Results will exclude the listed groups. Default: false.
@@ -936 +934 @@
             'include'            => false,
             'parent_id'          => null,
-            'populate_extras'    => true,
             'update_meta_cache'  => true,
             'update_admin_cache' => false,
@@ -1149 +1146 @@
         foreach ( (array) $paged_groups as $group ) {
             $group_ids[] = $group->id;
-        }
-
-        // Populate some extra information instead of querying each time in the loop.
-        if ( !empty( $r['populate_extras'] ) ) {
-            $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, $r['type'] );
         }