Changeset 11087 for trunk/tests/phpunit/testcases/groups/cache.php

Timestamp:

09/13/2016 04:05:07 AM (10 years ago)

Author:

boonebgorges

Message:

Groups: Improve query efficiency for 'admins' and 'mods' properties of group objects.

Previously, the 'admins' and 'mods' property of BP_Groups_Group
objects were only populated when setting the 'populate_extras' flag.
Even then, the query used to populate these properties was uncached,
and required a join against a global table.

This changeset reworks the way that the 'admins' and 'mods' properties
are accessed and set. The properties are now marked protected, and
are accessible by magic __get(). When requested, the cache for the
both properties is set by a single pair of queries: one to fetch
membership data from the BP table, and one to get user objects from
WordPress. The BP table query is cached, and neither query takes place
if the property is never accessed.

This moves us a step closer to eliminating the populate_extras flag
on BP_Groups_Group objects.

See #5451.

File:

• trunk/tests/phpunit/testcases/groups/cache.php (modified) (1 diff)

trunk/tests/phpunit/testcases/groups/cache.php

@@ -182 +182 @@
 
     /**
+     * @group groups_get_group_mods
+     */
+    public function test_groups_get_group_mods_cache() {
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
+        $g = $this->factory->group->create( array( 'creator_id' => $u1 ) );
+
+        // User 2 joins the group
+        groups_join_group( $g, $u2 );
+
+        // prime cache
+        groups_get_group_mods( $g );
+
+        // promote user 2 to an admin
+        bp_update_is_item_admin( true );
+        groups_promote_member( $u2, $g, 'mod' );
+
+        // assert new cached value
+        $this->assertEquals( 1, count( groups_get_group_mods( $g ) ) );
+    }
+
+    /**
+     * @group groups_get_group_mods
+     */
+    public function test_groups_get_group_mods_cache_on_member_save() {
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
+        $g = $this->factory->group->create( array( 'creator_id' => $u1 ) );
+
+        // prime cache
+        groups_get_group_mods( $g );
+
+        // promote user 2 to an admin via BP_Groups_Member::save()
+        self::add_user_to_group( $u2, $g, array( 'is_mod' => 1 ) );
+
+        // assert new cached value
+        $this->assertEquals( 1, count( groups_get_group_mods( $g ) ) );
+    }
+
+    /**
      * @group groups_get_group_admins
      */