Changeset 11083

Timestamp:

09/11/2016 01:53:40 PM (7 years ago)

Author:

djpaul

Message:

Groups: rename loop_start and loop_end actions.

This gives the Group Invitations and Group Members loops unique names for the actions called at the start and end of those templating loops. These are analagous to WordPress' Post templating loop with loop_start and loop_end, which is where the action names were likely copied from originally.

This has caused compatibility problems with plugins that hook to these actions that rightly expect the type of the first passed argument to be of WP_Query.

Fixes #7247

Props herbovec for reporting the issue.

Location:

trunk/src/bp-groups/classes

Files:

• class-bp-groups-group-members-template.php (modified) (2 diffs)
• class-bp-groups-invite-template.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group-members-template.php

@@ -240 +240 @@
              * @since 1.0.0
              * @since 2.3.0 `$this` parameter added.
+             * @since 2.7.0 Action renamed from `loop_end`.
              *
              * @param BP_Groups_Group_Members_Template $this Instance of the current Members template.
              */
-            do_action( 'loop_end', $this );
+            do_action( 'group_members_loop_end', $this );
 
             // Do some cleaning up after the loop.
@@ -270 +271 @@
              * @since 1.0.0
              * @since 2.3.0 `$this` parameter added.
+             * @since 2.7.0 Action renamed from `loop_start`.
              *
              * @param BP_Groups_Group_Members_Template $this Instance of the current Members template.
              */
-            do_action( 'loop_start', $this );
+            do_action( 'group_members_loop_start', $this );
         }
     }

trunk/src/bp-groups/classes/class-bp-groups-invite-template.php

@@ -198 +198 @@
              * @since 1.1.0
              * @since 2.3.0 `$this` parameter added.
+             * @since 2.7.0 Action renamed from `loop_start`.
              *
              * @param BP_Groups_Invite_Template $this Instance of the current Invites template.
              */
-            do_action( 'loop_end', $this );
+            do_action( 'group_invitation_loop_end', $this );
 
             // Do some cleaning up after the loop
@@ -262 +263 @@
              * @since 1.1.0
              * @since 2.3.0 `$this` parameter added.
+             * @since 2.7.0 Action renamed from `loop_start`.
              *
              * @param BP_Groups_Invite_Template $this Instance of the current Invites template.
              */
-            do_action( 'loop_start', $this );
+            do_action( 'group_invitation_loop_start', $this );
         }
     }