Changeset 11067 for trunk/src/bp-core/classes/class-bp-user-query.php

Timestamp:

09/06/2016 07:34:00 PM (9 years ago)

Author:

boonebgorges

Message:

Bail early if an array containing only 0 is passed to 'include' in user queries.

When 'include' is [ 0 ] or [ '0' ]`, there's no reason to run a costly
SQL query - we can immediately report no results.

Fixes #7248.

File:

• trunk/src/bp-core/classes/class-bp-user-query.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-user-query.php

@@ -365 +365 @@
         $include     = false !== $include ? wp_parse_id_list( $include ) : array();
         $include_ids = $this->get_include_ids( $include );
-        if ( ! empty( $include_ids ) ) {
+
+        // An array containing nothing but 0 should always fail.
+        if ( 1 === count( $include_ids ) && 0 == reset( $include_ids ) ) {
+            $sql['where'][] = $this->no_results['where'];
+        } elseif ( ! empty( $include_ids ) ) {
             $include_ids    = implode( ',', wp_parse_id_list( $include_ids ) );
             $sql['where'][] = "u.{$this->uid_name} IN ({$include_ids})";