Changeset 11065 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

09/06/2016 06:57:41 PM (8 years ago)

Author:

r-a-y

Message:

Groups: Cast properties as integers in BP_Groups_Group::get().

See #6977.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (3 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -978 +978 @@
          */
         $total_groups_sql = apply_filters( 'bp_groups_get_total_groups_sql', $t_sql, $total_sql, $r );
-        $total_groups     = $wpdb->get_var( $total_groups_sql );
+        $total_groups     = (int) $wpdb->get_var( $total_groups_sql );
 
         $group_ids = array();
@@ -993 +993 @@
         if ( ! empty( $r['update_meta_cache'] ) ) {
             bp_groups_update_meta_cache( $group_ids );
+        }
+
+        // Set up integer properties needing casting.
+        $int_props = array(
+            'id', 'creator_id', 'enable_forum', 'total_member_count',
+        );
+
+        // Integer casting.
+        foreach ( $paged_groups as $key => $g ) {
+            foreach ( $int_props as $int_prop ) {
+                $paged_groups[ $key ]->{$int_prop} = (int) $paged_groups[ $key ]->{$int_prop};
+            }
         }
 
@@ -1432 +1444 @@
 
         foreach ( $paged_groups as &$group ) {
-            $group->is_member  = groups_is_user_member( $user_id, $group->id ) ? '1' : '0';
-            $group->is_invited = groups_is_user_invited( $user_id, $group->id ) ? '1' : '0';
-            $group->is_pending = groups_is_user_pending( $user_id, $group->id ) ? '1' : '0';
+            $group->is_member  = groups_is_user_member( $user_id, $group->id )  ? 1 : 0;
+            $group->is_invited = groups_is_user_invited( $user_id, $group->id ) ? 1 : 0;
+            $group->is_pending = groups_is_user_pending( $user_id, $group->id ) ? 1 : 0;
             $group->is_banned  = (bool) groups_is_user_banned( $user_id, $group->id );
         }