Changeset 11029 for trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

Timestamp:

08/22/2016 10:35:29 PM (8 years ago)

Author:

r-a-y

Message:

Notifications: Cast properties as integers where appropriate.

See #6977.

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (4 diffs)

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -98 +98 @@
     public function __construct( $id = 0 ) {
         if ( ! empty( $id ) ) {
-            $this->id = $id;
+            $this->id = (int) $id;
             $this->populate();
         }
@@ -186 +186 @@
         // Setup the notification data.
         if ( ! empty( $notification ) && ! is_wp_error( $notification ) ) {
-            $this->item_id           = $notification->item_id;
-            $this->secondary_item_id = $notification->secondary_item_id;
-            $this->user_id           = $notification->user_id;
+            $this->item_id           = (int) $notification->item_id;
+            $this->secondary_item_id = (int) $notification->secondary_item_id;
+            $this->user_id           = (int) $notification->user_id;
             $this->component_name    = $notification->component_name;
             $this->component_action  = $notification->component_action;
             $this->date_notified     = $notification->date_notified;
-            $this->is_new            = $notification->is_new;
+            $this->is_new            = (int) $notification->is_new;
         }
     }
@@ -685 +685 @@
         $results = $wpdb->get_results( $sql );
 
+        // Integer casting.
+        foreach ( $results as $key => $result ) {
+            $results[$key]->id                = (int) $results[$key]->id;
+            $results[$key]->user_id           = (int) $results[$key]->user_id;
+            $results[$key]->item_id           = (int) $results[$key]->item_id;
+            $results[$key]->secondary_item_id = (int) $results[$key]->secondary_item_id;
+            $results[$key]->is_new            = (int) $results[$key]->is_new;
+        }
+
         // Update meta cache.
         if ( true === $r['update_meta_cache'] ) {
@@ -741 +750 @@
 
         // Return the queried results.
-        return $wpdb->get_var( $sql );
+        return (int) $wpdb->get_var( $sql );
     }