Changeset 11027 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

08/22/2016 10:11:20 PM (10 years ago)

Author:

r-a-y

Message:

Groups: Cast properties as integers where appropriate.

See #6977.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (6 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -176 +176 @@
 
                 if ( !empty( $id ) ) {
-                        $this->id = $id;
+                        $this->id = (int) $id;
                         $this->populate();
                 }
@@ -209 +209 @@
 
                 // Group found so setup the object variables.
-                $this->id           = $group->id;
-                $this->creator_id   = $group->creator_id;
+                $this->id           = (int) $group->id;
+                $this->creator_id   = (int) $group->creator_id;
                 $this->name         = stripslashes( $group->name );
                 $this->slug         = $group->slug;
                 $this->description  = stripslashes( $group->description );
                 $this->status       = $group->status;
-                $this->enable_forum = $group->enable_forum;
+                $this->enable_forum = (int) $group->enable_forum;
                 $this->date_created = $group->date_created;
 
@@ -232 +232 @@
                         // Add admins and moderators to their respective arrays.
                         foreach ( (array) $admin_mods as $user ) {
+                                $user->user_id  = (int) $user->user_id;
+                                $user->is_admin = (int) $user->is_admin;
+                                $user->is_mod   = (int) $user->is_mod;
+
                                 if ( !empty( $user->is_admin ) ) {
                                         $this->admins[] = $user;
@@ -242 +246 @@
                         // from the bp_groups cache because it's cached independently.
                         $this->last_activity      = groups_get_groupmeta( $this->id, 'last_activity' );
-                        $this->total_member_count = groups_get_groupmeta( $this->id, 'total_member_count' );
+                        $this->total_member_count = (int) groups_get_groupmeta( $this->id, 'total_member_count' );
 
                         // Set user-specific data.
@@ -436 +440 @@
          * @param string|bool $table_name Optional. Name of the table to check
          *                                against. Default: $bp->groups->table_name.
-         * @return string|null ID of the group, if one is found, else null.
+         * @return int|null Group ID if found; null if not.
          */
         public static function group_exists( $slug, $table_name = false ) {
@@ -447 +451 @@
                         return false;
 
-                return $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$table_name} WHERE slug = %s", strtolower( $slug ) ) );
+                $query = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$table_name} WHERE slug = %s", strtolower( $slug ) ) );
+
+                return is_numeric( $query ) ? (int) $query : $query;
         }