Changeset 11015

Timestamp:

08/16/2016 12:53:03 PM (5 years ago)

Author:

djpaul

Message:

Notifications: fix bp_notification_before_save filter being called too late to allow changes to notification.

Fixes #7213

Props wordpressrene

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (2 diffs)

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -113 +113 @@
      */
     public function save() {
-
-        // Return value.
         $retval = false;
 
-        // Default data and format.
+        /**
+         * Fires before the current notification item gets saved.
+         *
+         * Please use this hook to filter the properties above. Each part will be passed in.
+         *
+         * @since 2.0.0
+         *
+         * @param BP_Notifications_Notification $value Current instance of the notification item being saved. Passed by reference.
+         */
+        do_action_ref_array( 'bp_notification_before_save', array( &$this ) );
+
         $data = array(
             'user_id'           => $this->user_id,
@@ -128 +136 @@
         );
         $data_format = array( '%d', '%d', '%d', '%s', '%s', '%s', '%d' );
-
-        /**
-         * Fires before the current notification item gets saved.
-         *
-         * Please use this hook to filter the properties above. Each part will be passed in.
-         *
-         * @since 2.0.0
-         *
-         * @param BP_Notifications_Notification $value Current instance of the notification item being saved. Passed by reference.
-         */
-        do_action_ref_array( 'bp_notification_before_save', array( &$this ) );
 
         // Update.