Changeset 11008 for trunk/src/bp-groups/bp-groups-widgets.php

Timestamp:

08/10/2016 12:55:49 PM (8 years ago)

Author:

djpaul

Message:

Fix inaccurate timestamps caused by page caching.

If any template with a timestamp is statically cached, then the timestamps quickly become inaccurate.
The change adds livestamp.js and moment.js to dynamically update timestamps with the real relative time.

A consequence is that the labels surrounding the timestamps, notably in our widgets, have slightly changed.
We're going to keep an eye on this for the remainder of the 2.7 development cycle, and may make further adjustments as testing proves necessary.

Fixes #5757

Props r-a-y, imath, DJPaul

File:

• trunk/src/bp-groups/bp-groups-widgets.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-widgets.php

@@ -66 +66 @@
                     <div class="item-title"><a href="<?php bp_group_permalink() ?>" title="<?php bp_group_name() ?>"><?php bp_group_name() ?></a></div>
                     <div class="item-meta">
-                        <span class="activity">
-                            <?php
-                            if ( 'newest-groups' == $_POST['filter'] ) {
-                                printf( __( 'created %s', 'buddypress' ), bp_get_group_date_created() );
-                            } elseif ( 'recently-active-groups' == $_POST['filter'] ) {
-                                printf( __( 'active %s', 'buddypress' ), bp_get_group_last_active() );
-                            } elseif ( 'popular-groups' == $_POST['filter'] ) {
-                                bp_group_member_count();
-                            }
-                            ?>
-                        </span>
+                        <?php if ( 'newest-groups' === $_POST['filter'] ) : ?>
+                            <span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_group_date_created( 0, array( 'relative' => false ) ) ); ?>"><?php printf( __( 'created %s', 'buddypress' ), bp_get_group_date_created() ); ?></span>
+                        <?php elseif ( 'recently-active-groups' === $_POST['filter'] ) : ?>
+                            <span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_group_last_active( 0, array( 'relative' => false ) ) ); ?>"><?php printf( __( 'active %s', 'buddypress' ), bp_get_group_last_active() ); ?></span>
+                        <?php else : ?>
+                            <span class="activity"><?php bp_group_member_count(); ?></span>
+                        <?php endif; ?>
                     </div>
                 </div>