Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
08/10/2016 12:55:49 PM (4 years ago)
Author:
djpaul
Message:

Fix inaccurate timestamps caused by page caching.

If any template with a timestamp is statically cached, then the timestamps quickly become inaccurate.
The change adds livestamp.js and moment.js to dynamically update timestamps with the real relative time.

A consequence is that the labels surrounding the timestamps, notably in our widgets, have slightly changed.
We're going to keep an eye on this for the remainder of the 2.7 development cycle, and may make further adjustments as testing proves necessary.

Fixes #5757

Props r-a-y, imath, DJPaul

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-friends/classes/class-bp-core-friends-widget.php

    r10809 r11008  
    118118                            <div class="item-title fn"><a href="<?php bp_member_permalink(); ?>" title="<?php bp_member_name(); ?>"><?php bp_member_name(); ?></a></div>
    119119                            <div class="item-meta">
    120                                 <span class="activity">
    121                                 <?php
    122                                     if ( 'newest' == $instance['friend_default'] )
    123                                         bp_member_registered();
    124                                     if ( 'active' == $instance['friend_default'] )
    125                                         bp_member_last_active();
    126                                     if ( 'popular' == $instance['friend_default'] )
    127                                         bp_member_total_friend_count();
    128                                 ?>
    129                                 </span>
     120                                <?php if ( 'newest' == $instance['friend_default'] ) : ?>
     121                                    <span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_member_registered( array( 'relative' => false ) ) ); ?>"><?php bp_member_registered(); ?></span>
     122                                <?php elseif ( 'active' == $instance['friend_default'] ) : ?>
     123                                    <span class="activity" data-livestamp="<?php bp_core_iso8601_date( bp_get_member_last_activity( array( 'relative' => false ) ) ); ?>"><?php bp_member_last_active(); ?></span>
     124                                <?php else : ?>
     125                                    <span class="activity"><?php bp_member_total_friend_count(); ?></span>
     126                                <?php endif; ?>
    130127                            </div>
    131128                        </div>
Note: See TracChangeset for help on using the changeset viewer.