Changeset 11008 for trunk/src/bp-activity/bp-activity-template.php

Timestamp:

08/10/2016 12:55:49 PM (10 years ago)

Author:

djpaul

Message:

Fix inaccurate timestamps caused by page caching.

If any template with a timestamp is statically cached, then the timestamps quickly become inaccurate.
The change adds livestamp.js and moment.js to dynamically update timestamps with the real relative time.

A consequence is that the labels surrounding the timestamps, notably in our widgets, have slightly changed.
We're going to keep an eye on this for the remainder of the 2.7 development cycle, and may make further adjustments as testing proves necessary.

Fixes #5757

Props r-a-y, imath, DJPaul

File:

• trunk/src/bp-activity/bp-activity-template.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-template.php

@@ -1477 +1477 @@
         $date_recorded  = bp_core_time_since( $activities_template->activity->date_recorded );
 
+        // Set up 'time-since' <span>.
+        $time_since = sprintf(
+                '<span class="time-since" data-livestamp="%1$s">%2$s</span>',
+                bp_core_get_iso8601_date( $activities_template->activity->date_recorded ),
+                $date_recorded
+        );
+
         /**
          * Filters the activity item time since markup.
@@ -1485 +1492 @@
          */
         $time_since = apply_filters_ref_array( 'bp_activity_time_since', array(
-                '<span class="time-since">' . $date_recorded . '</span>',
+                $time_since,
                 &$activities_template->activity
         ) );