Changeset 10977 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

08/01/2016 08:09:35 PM (8 years ago)

Author:

boonebgorges

Message:

In bp_get_user_groups(), initialize key whitelists only once.

Creating them during every iteration of the groups loop is unnecessary.

See #7208.

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-functions.php

@@ -876 +876 @@
 
     // Normalize group data.
+    $int_keys  = array( 'id', 'group_id', 'user_id', 'inviter_id' );
+    $bool_keys = array( 'is_admin', 'is_mod', 'is_confirmed', 'is_banned', 'invite_sent' );
     foreach ( $groups as &$group ) {
         // Integer values.
-        foreach ( array( 'id', 'group_id', 'user_id', 'inviter_id' ) as $index ) {
+        foreach ( $int_keys as $index ) {
             $group->{$index} = intval( $group->{$index} );
         }
 
         // Boolean values.
-        foreach ( array( 'is_admin', 'is_mod', 'is_confirmed', 'is_banned', 'invite_sent' ) as $index ) {
+        foreach ( $bool_keys as $index ) {
             $group->{$index} = (bool) $group->{$index};
         }