Changeset 10941 for trunk/src/bp-friends/bp-friends-notifications.php

Timestamp:

07/10/2016 09:46:27 PM (9 years ago)

Author:

djpaul

Message:

Emails: add unsubscribe feature.

Updates the unsubscribe token to link to a new unsubscribe action handler.

All emails from other platforms or popular websites have a unsubscribe link. For previous versions of BuddyPress, our unsubscribe link pointed to that user's notifications page. However, if someone creates an account on a BuddyPress with a fraudulent email address (for example), that email address' owner will not know the account's authentication details, and so have no way to unsubscribe from that "spam" email.

The change implements a new action handler which accepts unsubscription requests from un-authenticated requests. It adds an new option containing a dynamically generated salt which is used to generate the hash on the unsubscribe link.

Fixes #6932

Props tharsheblows, DJPaul

File:

• trunk/src/bp-friends/bp-friends-notifications.php (modified) (4 diffs)

trunk/src/bp-friends/bp-friends-notifications.php

@@ -32 +32 @@
         return;
     }
+
+    $unsubscribe_args = array(
+        'user_id'           => $friend_id,
+        'notification_type' => 'friends-request',
+    );
 
     $args = array(
@@ -41 +46 @@
             'initiator.url'       => esc_url( bp_core_get_user_domain( $initiator_id ) ),
             'initiator.name'      => bp_core_get_user_displayname( $initiator_id ),
+            'unsubscribe'         => esc_url( bp_email_get_unsubscribe_link( $unsubscribe_args ) ),
         ),
     );
@@ -63 +69 @@
         return;
     }
+
+    $unsubscribe_args = array(
+        'user_id'           => $initiator_id,
+        'notification_type' => 'friends-request-accepted',
+    );
 
     $args = array(
@@ -71 +82 @@
             'friendship.id'  => $friendship_id,
             'initiator.id'   => $initiator_id,
+            'unsubscribe'      => esc_url( bp_email_get_unsubscribe_link( $unsubscribe_args ) ),
         ),
     );