Changeset 10937

Timestamp:

07/06/2016 02:02:37 AM (8 years ago)

Author:

dcavins

Message:

Improve BP_Groups_Group::filter_user_groups().

Add a preceding wildcard to the LIKE search terms statement in
BP_Groups_Group::filter_user_groups(). Before this change, the
function would only find group names and descriptions that started with
the search string.

Location:

trunk

Files:

• src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)
• tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -507 +507 @@
             $user_id = bp_displayed_user_id();
 
-        $search_terms_like = bp_esc_like( $filter ) . '%';
+        $search_terms_like = '%' . bp_esc_like( $filter ) . '%';
 
         $pag_sql = $order_sql = $hidden_sql = '';

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -614 +614 @@
     }
 
+    public function test_filter_user_groups_normal_search_middle_of_string() {
+        $g1 = $this->factory->group->create( array(
+            'name' => 'Cool Group',
+            'description' => 'This group is for mandocellos and oboes.',
+        ) );
+        $g2 = $this->factory->group->create();
+        $u = $this->factory->user->create();
+        self::add_user_to_group( $u, $g1 );
+
+        $groups = BP_Groups_Group::filter_user_groups( 'cello', $u );
+
+        $found = wp_list_pluck( $groups['groups'], 'group_id' );
+        $this->assertEquals( array( $g1 ), $found );
+    }
+
     public function test_filter_user_groups_search_with_underscores() {
         $g1 = $this->factory->group->create( array(