Changeset 10908

Timestamp:

06/28/2016 05:25:48 AM (8 years ago)

Author:

r-a-y

Message:

Activity: Fix issue with activity permalink access when the legacy activity query is enabled.

In #7113, we fixed a bug where anybody's activity item could be displayed
under a member profile. The fix (r10880) does a strict type check on
$activity->user_id.

We expect $activity->user_id to be an integer, however it can be a
numeric string if the legacy activity query is enabled with:
add_filter( 'bp_use_legacy_activity_query', '__return_true' );

Since the check will always fail in this instance, members will not be able
to access activity permalinks.

We unfortunately missed this specific instance in r10853.

This commit addresses this problem.

See #6977. Fixes #7146 (trunk).

File:

• trunk/src/bp-activity/classes/class-bp-activity-activity.php (modified) (1 diff)

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -614 +614 @@
             }
 
+            // Integer casting for legacy activity query.
+            foreach ( (array) $activities as $i => $ac ) {
+                $activities[ $i ]->id                = (int) $ac->id;
+                $activities[ $i ]->item_id           = (int) $ac->item_id;
+                $activities[ $i ]->secondary_item_id = (int) $ac->secondary_item_id;
+                $activities[ $i ]->user_id           = (int) $ac->user_id;
+                $activities[ $i ]->hide_sitewide     = (int) $ac->hide_sitewide;
+                $activities[ $i ]->mptt_left         = (int) $ac->mptt_left;
+                $activities[ $i ]->mptt_right        = (int) $ac->mptt_right;
+                $activities[ $i ]->is_spam           = (int) $ac->is_spam;
+            }
+
         } else {
             // Query first for activity IDs.