Changeset 10905

Timestamp:

06/27/2016 03:07:47 AM (10 years ago)

Author:

imath

Message:

Groups: Make sure BP_Group_Extension::widget_display() can be used

On the single item home (eg: a custom front template), it will now be possible to use bp_custom_group_boxes() to get the content provided by the Group extensions in their widget.

2 unit tests are checking this only happens when on the Groups single item home.

Fixes #7131

Location:

trunk

Files:

• src/bp-groups/classes/class-bp-group-extension.php (modified) (1 diff)
• tests/phpunit/assets/group-extensions.php (modified) (1 diff)
• tests/phpunit/testcases/groups/class-bp-group-extension.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-group-extension.php

@@ -764 +764 @@
 
                 // Hook the group home widget.
-                if ( ! bp_current_action() && bp_is_current_action( 'home' ) ) {
+                if ( bp_is_group_home() ) {
                         add_action( $this->display_hook, array( &$this, 'widget_display' ) );
                 }

trunk/tests/phpunit/assets/group-extensions.php

@@ -410 +410 @@
         }
 }
+
+class BPTest_Group_Extension_Widget_Method extends BP_Group_Extension {
+        public function __construct() {
+                $class_name = get_class( $this );
+
+                $args = array(
+                        'name' => $class_name,
+                        'slug' => sanitize_title( $class_name ),
+                );
+
+                parent::init( $args );
+        }
+
+        public function widget_display() {
+                echo 'Widget Displayed';
+        }
+}

trunk/tests/phpunit/testcases/groups/class-bp-group-extension.php

@@ -846 +846 @@
                 $this->set_current_user( $old_current_user );
         }
+
+        /**
+         * @ticket BP7131
+         */
+        public function test_widget_on_group_home_page() {
+                $g = $this->factory->group->create( array(
+                        'status' => 'public',
+                ) );
+                $g_obj = groups_get_group( array( 'group_id' => $g ) );
+
+                $this->go_to( bp_get_group_permalink( $g_obj ) );
+
+                $e1 = new BPTest_Group_Extension_Widget_Method();
+                $e1->_register();
+
+                ob_start();
+                bp_custom_group_boxes();
+                $content = ob_get_clean();
+
+                $this->assertTrue( $content === 'Widget Displayed' );
+        }
+
+        /**
+         * @ticket BP7131
+         */
+        public function test_widget_on_group_members_page() {
+                $g = $this->factory->group->create( array(
+                        'status' => 'public',
+                ) );
+                $g_obj = groups_get_group( array( 'group_id' => $g ) );
+
+                $this->go_to( trailingslashit( bp_get_group_permalink( $g_obj ) ) . 'members/' );
+
+                $e1 = new BPTest_Group_Extension_Widget_Method();
+                $e1->_register();
+
+                ob_start();
+                bp_custom_group_boxes();
+                $content = ob_get_clean();
+
+                $this->assertFalse( $content === 'Widget Displayed' );
+        }
 }