Changeset 10877

Timestamp:

06/10/2016 05:39:34 PM (10 years ago)

Author:

dcavins

Message:

Invalidate profile field cache on update.

When a profile field’s position is updated in
BP_XProfile_Field::update_position(), the
cached field data was not cleared. This caused
the field to look like it was unchanged.

Fixes #7112.

Props @emrikol, @r-a-y.

Location:

trunk

Files:

• src/bp-xprofile/classes/class-bp-xprofile-field.php (modified) (1 diff)
• tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php (modified) (1 diff)

trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php

@@ -943 +943 @@
                         $sql = $wpdb->prepare( "UPDATE {$table_name} SET group_id = %d WHERE parent_id = %d", $field_group_id, $field_id );
                         $wpdb->query( $sql );
+
+                        // Invalidate profile field cache.
+                        wp_cache_delete( $field_id, 'bp_xprofile_fields' );
 
                         return $parent;

trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php

@@ -184 +184 @@
                 $this->assertFalse( wp_cache_get( 12345, 'bp_xprofile_fields' ) );
         }
+
+        /**
+         * @ticket BP7112
+         */
+        public function test_update_position_should_invalidate_cache() {
+                $group = $this->factory->xprofile_group->create();
+                $field = $this->factory->xprofile_field->create( array(
+                        'field_group_id' => $group,
+                ) );
+
+                // Prime cache.
+                $fetched_field = xprofile_get_field( $field );
+                $new_field_order = 12345;
+
+                // Update field position.
+                BP_XProfile_Field::update_position( $field, $new_field_order, $group );
+
+                // Cache call should miss; fresh data should be fetched.
+                $updated_fetched_field = xprofile_get_field( $field );
+                $this->assertEquals( $new_field_order, $updated_fetched_field->field_order );
+        }
 }