Changeset 10864 for trunk/src/bp-activity/bp-activity-embeds.php

Timestamp:

06/01/2016 10:39:41 PM (8 years ago)

Author:

r-a-y

Message:

Activity Embeds: Use CSS asset file for inline CSS.

Previously, we were using a template part to grab the inline CSS. This
is not a great idea.

Instead, we are using the actual CSS file and including it inline.

See #7104, #6772.

File:

• trunk/src/bp-activity/bp-activity-embeds.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-embeds.php

@@ -55 +55 @@
  * Add inline styles for BP activity embeds.
  *
- * This is subject to change or be removed entirely for a different system.
- * Potentially for BP_Legacy::locate_asset_in_stack().
- *
  * @since  2.6.0
- * @access private
- */
-function _bp_activity_embed_add_inline_styles() {
+ */
+function bp_activity_embed_add_inline_styles() {
     if ( false === bp_is_single_activity() ) {
         return;
     }
 
-    ob_start();
+    $min = bp_core_get_minified_asset_suffix();
+
     if ( is_rtl() ) {
-        bp_get_asset_template_part( 'embeds/css-activity', 'rtl' );
+        $css = bp_locate_template_asset( "assets/embeds/activity-rtl{$min}.css" );
     } else {
-        bp_get_asset_template_part( 'embeds/css-activity' );
-    }
-    $css = ob_get_clean();
-
-    // Rudimentary CSS protection.
+        $css = bp_locate_template_asset( "assets/embeds/activity{$min}.css" );
+    }
+
+    // Bail if file wasn't found.
+    if ( false === $css ) {
+        return;
+    }
+
+    // Grab contents of CSS file and do some rudimentary CSS protection.
+    $css = file_get_contents( $css['file'] );
     $css = wp_kses( $css, array( "\'", '\"' ) );
 
     printf( '<style type="text/css">%s</style>', $css );
 }
-add_action( 'embed_head', '_bp_activity_embed_add_inline_styles', 20 );
+add_action( 'embed_head', 'bp_activity_embed_add_inline_styles', 20 );
 
 /**