Changeset 10817

Timestamp:

05/27/2016 06:05:31 AM (9 years ago)

Author:

r-a-y

Message:

Notifications: Don't use object buffering in template tags.

Use sprintf() instead.

See r7539.

File:

• trunk/src/bp-notifications/bp-notifications-template.php (modified) (3 diffs)

trunk/src/bp-notifications/bp-notifications-template.php

@@ -560 +560 @@
         $user_id = 0 === $user_id ? bp_displayed_user_id() : $user_id;
 
-        // Start the output buffer.
-        ob_start(); ?>
-
-        <a href="<?php bp_the_notification_mark_read_url( $user_id ); ?>" class="mark-read primary"><?php _e( 'Read', 'buddypress' ); ?></a>
-
-        <?php $retval = ob_get_clean();
+        $retval = sprintf( '<a href="%1$s" class="mark-read primary">%2$s</a>', esc_url( bp_get_the_notification_mark_read_url( $user_id ) ), __( 'Read', 'buddypress' ) );
 
         /**
@@ -657 +652 @@
         $user_id = 0 === $user_id ? bp_displayed_user_id() : $user_id;
 
-        // Start the output buffer.
-        ob_start(); ?>
-
-        <a href="<?php bp_the_notification_mark_unread_url( $user_id ); ?>" class="mark-unread primary"><?php _ex( 'Unread',  'Notification screen action', 'buddypress' ); ?></a>
-
-        <?php $retval = ob_get_clean();
+        $retval = sprintf( '<a href="%1$s" class="mark-unread primary">%2$s</a>', esc_url( bp_get_the_notification_mark_unread_url( $user_id ) ), __( 'Unread', 'buddypress' ) );
 
         /**
@@ -796 +786 @@
         $user_id = 0 === $user_id ? bp_displayed_user_id() : $user_id;
 
-        // Start the output buffer.
-        ob_start(); ?>
-
-        <a href="<?php bp_the_notification_delete_url(); ?>" class="delete secondary confirm"><?php _e( 'Delete', 'buddypress' ); ?></a>
-
-        <?php $retval = ob_get_clean();
+        $retval = sprintf( '<a href="%1$s" class="delete secondary confirm">%2$s</a>', esc_url( bp_get_the_notification_delete_url( $user_id ) ), __( 'Delete', 'buddypress' ) );
 
         /**