Changeset 10814 for trunk/src/bp-core/bp-core-customizer-email.php

Timestamp:

05/26/2016 07:56:30 PM (9 years ago)

Author:

dcavins

Message:

Use absint() to validate numeric input in the WP Customizer.

intval() fails when used with the WP
Customizer API as a sanitization callback.
The callback function is attached to
a filter in WP_Customize_Setting::sanitize()
that passes two arguments to the
sanitization callback: the $value to sanitize
and the instance of WP_Customize_Setting.
Since intval() can accept an optional
second argument ($base), but isn’t
expecting an object, it fails.
absint() works because it is only
expecting the $value argument.

Fixes #7041.

Props WeddyWood.

File:

• trunk/src/bp-core/bp-core-customizer-email.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-customizer-email.php

@@ -195 +195 @@
             'capability'        => 'bp_moderate',
             'default'           => $defaults['header_text_size'],
-            'sanitize_callback' => 'intval',
+            'sanitize_callback' => 'absint',
             'transport'         => 'postMessage',
             'type'              => 'option',
@@ -223 +223 @@
             'capability'        => 'bp_moderate',
             'default'           => $defaults['body_text_size'],
-            'sanitize_callback' => 'intval',
+            'sanitize_callback' => 'absint',
             'transport'         => 'postMessage',
             'type'              => 'option',
@@ -251 +251 @@
             'capability'        => 'bp_moderate',
             'default'           => $defaults['footer_text_size'],
-            'sanitize_callback' => 'intval',
+            'sanitize_callback' => 'absint',
             'transport'         => 'postMessage',
             'type'              => 'option',