Skip to:
Content

BuddyPress.org

Changeset 10807


Ignore:
Timestamp:
05/25/2016 04:38:11 PM (10 years ago)
Author:
dcavins
Message:

RTL CSS generation: Move from CSSJanus to RTLCSS.

Moving to the grunt tool RTLCSS for right-to-left
CSS generation keeps us in step with WordPress.
RTLCSS also natively handles more properties than
CSSJanus.

See #7007.

Props netweb.

Location:
trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Gruntfile.js

    r10771 r10807  
    99        ],
    1010
    11         // CSS exclusions, for excluding files from certain tasks, e.g. cssjanus
     11        // CSS exclusions, for excluding files from certain tasks, e.g. rtlcss
    1212        BP_EXCLUDED_CSS = [
    1313            '!**/*-rtl.css'
    … …  
    9292            }
    9393        },
    94         cssjanus: {
     94        rtlcss: {
     95            options: {
     96                opts: {
     97                    processUrls: false,
     98                    autoRename: false,
     99                    clean: true
     100                },
     101                saveUnmodified: false
     102            },
    95103            core: {
    96104                expand: true,
    … …  
    99107                extDot: 'last',
    100108                ext: '-rtl.css',
    101                 src: BP_CSS.concat( BP_EXCLUDED_CSS, BP_EXCLUDED_MISC ),
    102                 options: { generateExactDuplicates: true }
     109                src: BP_CSS.concat( BP_EXCLUDED_CSS, BP_EXCLUDED_MISC )
    103110            }
    104111        },
    … …  
    249256     * Register tasks.
    250257     */
    251     grunt.registerTask( 'src',     ['checkDependencies', 'jsvalidate:src', 'jshint', 'scsslint', 'sass', 'cssjanus'] );
     258    grunt.registerTask( 'src',     ['checkDependencies', 'jsvalidate:src', 'jshint', 'scsslint', 'sass', 'rtlcss'] );
    252259    grunt.registerTask( 'commit',  ['src', 'checktextdomain', 'imagemin'] );
    253260    grunt.registerTask( 'build',   ['commit', 'clean:all', 'copy:files', 'uglify', 'jsvalidate:build', 'cssmin', 'makepot', 'exec:bpdefault'] );

  • trunk/package.json

    r10704 r10807  
    1515    "grunt-contrib-uglify": "~0.10.1",
    1616    "grunt-contrib-watch": "~1.0.0",
    17     "grunt-cssjanus": "~0.2.4",
    1817    "grunt-exec": "~0.4.6",
    1918    "grunt-check-dependencies": "~0.12.0",
    … …  
    2120    "grunt-legacy-util": "^0.2.0",
    2221    "grunt-patch-wordpress": "~0.3.0",
     22    "grunt-rtlcss": "~2.0.1",
    2323    "grunt-sass": "~1.1.0",
    2424    "grunt-scss-lint": "~0.3.8",

  • trunk/src/bp-activity/css/mentions.css

    r10695 r10807  
    1212    z-index: 1000; /* >999 for wp-admin */
    1313}
    14 /* @noflip */
     14/* rtl:ignore */
    1515.atwho-view {
    16     left: 0; 
     16    left: 0;
    1717}
    1818.atwho-view ul {
Note: See TracChangeset for help on using the changeset viewer.