Changeset 10800 for trunk/src/bp-core/classes/class-bp-attachment-cover-image.php

Timestamp:

05/24/2016 02:34:37 PM (10 years ago)

Author:

boonebgorges

Message:

Better hash building for activation keys, password reset keys, and filenames.

There is no need to use user-facing info for these hashes.

Props DJPaul, vortfu.

File:

• trunk/src/bp-core/classes/class-bp-attachment-cover-image.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-attachment-cover-image.php

@@ -209 +209 @@
         }
 
-        $info    = pathinfo( $file );
-        $dir     = $info['dirname'];
-        $ext     = strtolower( $info['extension'] );
-        $name    = wp_hash( $file . time() ) . '-bp-cover-image';
-
-        return trailingslashit( $dir ) . "{$name}.{$ext}";
+        $info = pathinfo( $file );
+        $ext  = strtolower( $info['extension'] );
+        $name = wp_unique_filename( $info['dirname'], uniqid() . "-bp-cover-image.$ext" );
+
+        return trailingslashit( $info['dirname'] ) . $name;
     }