Changeset 10794 for trunk/tests/phpunit/testcases/groups/functions/groupsIsUser.php

Timestamp:

05/21/2016 02:16:38 AM (9 years ago)

Author:

boonebgorges

Message:

Introduce caching for group memberships.

The new system works like this: The bp_groups_memberships_for_user cache
group stores arrays of membership IDs for individual users. The
bp_groups_memberships cache group stores data about individual memberships.
The new function bp_get_user_groups() populates a user's group memberships
from these caches, and filters them as requested in the function parameters.
Then, the various groups_is_user_*() functions use bp_get_user_groups()
instead of direct, uncached database queries to fetch their data.

In addition, the get_group_extras() method of BP_Groups_Group can now be
greatly simplified, since all necessary pre-fetching of current-user group
memberships happens via the bp_get_user_groups() cache.

Props boonebgorges, dcavins.
See #6327.

File:

• trunk/tests/phpunit/testcases/groups/functions/groupsIsUser.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/groups/functions/groupsIsUser.php

@@ -55 +55 @@
         ) );
 
-        $this->assertEquals( true, groups_is_user_admin( self::$user, self::$groups[1] ) );
+        $this->assertNotEmpty( groups_is_user_admin( self::$user, self::$groups[1] ) );
     }
 
@@ -77 +77 @@
         ) );
 
-        $this->assertEquals( true, groups_is_user_mod( self::$user, self::$groups[1] ) );
+        $this->assertNotEmpty( groups_is_user_mod( self::$user, self::$groups[1] ) );
     }
 
@@ -108 +108 @@
         $this->add_user_to_group( self::$user, self::$groups[1] );
 
-        $this->assertEquals( true, groups_is_user_member( self::$user, self::$groups[1] ) );
+        $this->assertNotEmpty( groups_is_user_member( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_member_should_return_true_for_admin() {
+        $this->add_user_to_group( self::$user, self::$groups[1], array(
+            'is_admin' => true,
+        ) );
+
+        $this->assertNotEmpty( groups_is_user_member( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_member_should_return_true_for_mod() {
+        $this->add_user_to_group( self::$user, self::$groups[1], array(
+            'is_mod' => true,
+        ) );
+
+        $this->assertNotEmpty( groups_is_user_member( self::$user, self::$groups[1] ) );
     }
 
@@ -144 +160 @@
         $m->ban();
 
-        $this->assertEquals( true, groups_is_user_banned( self::$user, self::$groups[1] ) );
+        $this->assertNotEmpty( groups_is_user_banned( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_invited_should_return_false_for_confirmed_member() {
+        $this->add_user_to_group( self::$user, self::$groups[1] );
+        $this->assertEquals( false, groups_is_user_invited( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_invited_should_return_false_for_uninvited_member() {
+        $this->assertEquals( false, groups_is_user_invited( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_invited_should_return_true_for_invited_member() {
+        $i = groups_invite_user( array(
+            'user_id' => self::$user,
+            'group_id' => self::$groups[1],
+            'inviter_id' => 123,
+        ) );
+
+        // Send invite.
+        $m = new BP_Groups_Member( self::$user, self::$groups[1] );
+        $m->invite_sent = 1;
+        $m->save();
+
+        $this->assertNotEmpty( groups_is_user_invited( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_pending_should_return_false_for_pending_member() {
+        groups_invite_user( array(
+            'user_id' => self::$user,
+            'group_id' => self::$groups[1],
+            'inviter_id' => 123,
+        ) );
+
+        // Send invite.
+        $m = new BP_Groups_Member( self::$user, self::$groups[1] );
+        $m->invite_sent = 1;
+        $m->save();
+
+        $this->assertEquals( false, groups_is_user_pending( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_pending_should_return_false_for_member_with_no_request() {
+        $this->assertEquals( false, groups_is_user_pending( self::$user, self::$groups[1] ) );
+    }
+
+    public function test_groups_is_user_pending_should_return_true_for_pending_member() {
+
+        $m                = new BP_Groups_Member;
+        $m->group_id      = self::$groups[1];
+        $m->user_id       = self::$user;
+        $m->inviter_id    = 0;
+        $m->is_admin      = 0;
+        $m->user_title    = '';
+        $m->date_modified = bp_core_current_time();
+        $m->is_confirmed  = 0;
+        $m->comments      = 'request';
+        $m->save();
+
+        $this->assertNotEmpty( groups_is_user_pending( self::$user, self::$groups[1] ) );
     }
 }