Changeset 10713

Timestamp:

04/20/2016 03:10:50 PM (8 years ago)

Author:

hnla

Message:

BP XProfile user edit screens
Commit updates radio, checkbox, datebox form controls to improve markup Standards & accessibility.

• Adds new classes to simplify targeting labels/inputs.
• Updates main css styles for labels to include fieldsets/legends.
• Updates wrapping 'divs' to fieldsets for better Standards & changes labels used for headings to 'legend' elements.
• Add new ruleset to buddypress.css to remove fieldset border & padding to ensure new elements do not disrupt existing site layouts.

Fixes #6678 Props dcavins, hnla, mercime

Location:

trunk/src

Files:

• bp-templates/bp-legacy/css/buddypress-rtl.css (modified) (2 diffs)
• bp-templates/bp-legacy/css/buddypress.css (modified) (2 diffs)
• bp-xprofile/classes/class-bp-xprofile-field-type-checkbox.php (modified) (1 diff)
• bp-xprofile/classes/class-bp-xprofile-field-type-radiobutton.php (modified) (1 diff)

trunk/src/bp-templates/bp-legacy/css/buddypress-rtl.css

@@ -617 +617 @@
 3.5 - Forms
 --------------------------------------------------------------*/
+
+#buddypress form fieldset {
+    border: 0;
+    padding: 0;
+}
+
 #buddypress .standard-form textarea,
 #buddypress .standard-form input[type=text],
@@ -673 +679 @@
     margin: 5px 0 0 0;
 }
+#buddypress .standard-form .checkbox label input,
+#buddypress .standard-form .radio label input {
+    margin-left: 3px;
+}
 #buddypress .standard-form#sidebar-login-form label {
     margin-top: 5px;

trunk/src/bp-templates/bp-legacy/css/buddypress.css

@@ -617 +617 @@
 3.5 - Forms
 --------------------------------------------------------------*/
+
+#buddypress form fieldset {
+    border: 0;
+    padding: 0;
+}
+
 #buddypress .standard-form textarea,
 #buddypress .standard-form input[type=text],
@@ -673 +679 @@
     margin: 5px 0 0 0;
 }
+#buddypress .standard-form .checkbox label input,
+#buddypress .standard-form .radio label input {
+    margin-right: 3px;
+}
 #buddypress .standard-form#sidebar-login-form label {
     margin-top: 5px;

trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-checkbox.php

@@ -155 +155 @@
             }
 
-            $new_html = sprintf( '<label for="%3$s"><input %1$s type="checkbox" name="%2$s" id="%3$s" value="%4$s">%5$s</label>',
+            $new_html = sprintf( '<label for="%3$s" class="option-label"><input %1$s type="checkbox" name="%2$s" id="%3$s" value="%4$s">%5$s</label>',
                 $selected,
                 esc_attr( "field_{$this->field_obj->id}[]" ),

trunk/src/bp-xprofile/classes/class-bp-xprofile-field-type-radiobutton.php

@@ -133 +133 @@
             }
 
-            $new_html = sprintf( '<label for="%3$s"><input %1$s type="radio" name="%2$s" id="%3$s" value="%4$s">%5$s</label>',
+            $new_html = sprintf( '<label for="%3$s" class="option-label"><input %1$s type="radio" name="%2$s" id="%3$s" value="%4$s">%5$s</label>',
                 $selected,
                 esc_attr( "field_{$this->field_obj->id}" ),