Changeset 10613 for trunk/src/bp-groups/bp-groups-admin.php

Timestamp:

02/18/2016 11:10:33 AM (11 years ago)

Author:

djpaul

Message:

Fix script/style enqueue path when using BP dev. repo. with release build of WP, and SCRIPT_DEBUG=false.

If you have a WordPress release build (that is, not the dev SVN with its src folder) with a BuddyPress dev build (with its src folder), and set SCRIPT_DEBUG=false, BuddyPress will try to load the minified versions of its CSS and JS assets. As these minified assets only exist in our release builds, this causes 404 errors in this particular set of circumstances.

Fixes #6920

File:

• trunk/src/bp-groups/bp-groups-admin.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-admin.php

@@ -79 +79 @@
         $redirect_to = remove_query_arg( array( 'action', 'action2', 'gid', 'deleted', 'error', 'updated', 'success_new', 'error_new', 'success_modified', 'error_modified' ), $_SERVER['REQUEST_URI'] );
 
-        // Decide whether to load the dev version of the CSS and JavaScript.
-        $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : 'min.';
-
-        $doaction = bp_admin_list_table_current_bulk_action();
+        $doaction   = bp_admin_list_table_current_bulk_action();
+        $min        = bp_core_get_minified_asset_suffix();
 
         /**
@@ -188 +186 @@
 
         // Enqueue CSS and JavaScript.
-        wp_enqueue_script( 'bp_groups_admin_js', $bp->plugin_url . "bp-groups/admin/js/admin.{$min}js", array( 'jquery', 'wp-ajax-response', 'jquery-ui-autocomplete' ), bp_get_version(), true );
+        wp_enqueue_script( 'bp_groups_admin_js', $bp->plugin_url . "bp-groups/admin/js/admin{$min}.js", array( 'jquery', 'wp-ajax-response', 'jquery-ui-autocomplete' ), bp_get_version(), true );
         wp_localize_script( 'bp_groups_admin_js', 'BP_Group_Admin', array(
                 'add_member_placeholder' => __( 'Start typing a username to add a new member.', 'buddypress' ),
                 'warn_on_leave'          => __( 'If you leave this page, you will lose any unsaved changes you have made to the group.', 'buddypress' ),
         ) );
-        wp_enqueue_style( 'bp_groups_admin_css', $bp->plugin_url . "bp-groups/admin/css/admin.{$min}css", array(), bp_get_version() );
+        wp_enqueue_style( 'bp_groups_admin_css', $bp->plugin_url . "bp-groups/admin/css/admin{$min}.css", array(), bp_get_version() );
 
         wp_style_add_data( 'bp_groups_admin_css', 'rtl', true );