Changeset 10579 for trunk/src/bp-members/classes/class-bp-members-admin.php

Timestamp:

02/12/2016 06:22:37 AM (10 years ago)

Author:

imath

Message:

Signups Administration: improve the screen management

r10547 introduced some regressions by setting the screen ID to users or users-network :

• It was not possible anymore to manage the displayed column inside the Screen options.
• All costum columns added to the Users List Table using the filter manage_users_columns or manage_users-network_columns were also added to the Signups List Table.

To fix these and also make sure it is still possible to add custom views before and after the pending view, we are now using the Signups screen ID and introducing a new function to temporarly set the screen ID to users or users-network when needed.

Fixes #6872

File:

• trunk/src/bp-members/classes/class-bp-members-admin.php (modified) (1 diff)

trunk/src/bp-members/classes/class-bp-members-admin.php

@@ -1325 +1325 @@
      */
     public function signup_filter_view( $views = array() ) {
+        global $role;
 
         // Remove the 'current' class from All if we're on the signups view.
-        if ( $this->signups_page == get_current_screen()->id ) {
+        if ( 'registered' === $role ) {
             $views['all'] = str_replace( 'class="current"', '', $views['all'] );
             $class        = 'current';