Changeset 10555 for trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php

Timestamp:

02/08/2016 05:56:22 AM (11 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php (modified) (3 diffs)

trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php

@@ -319 +319 @@
                         // View Profile.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-public',
-                                'title'  => _x( 'View', 'My Account Profile sub nav', 'buddypress' ),
-                                'href'   => $profile_link
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-public',
+                                'title'    => _x( 'View', 'My Account Profile sub nav', 'buddypress' ),
+                                'href'     => $profile_link,
+                                'position' => 10
                         );
 
                         // Edit Profile.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-edit',
-                                'title'  => _x( 'Edit', 'My Account Profile sub nav', 'buddypress' ),
-                                'href'   => trailingslashit( $profile_link . 'edit' )
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-edit',
+                                'title'    => _x( 'Edit', 'My Account Profile sub nav', 'buddypress' ),
+                                'href'     => trailingslashit( $profile_link . 'edit' ),
+                                'position' => 20
                         );
 
@@ -336 +338 @@
                         if ( buddypress()->avatar->show_avatars ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-change-avatar',
-                                        'title'  => _x( 'Change Profile Photo', 'My Account Profile sub nav', 'buddypress' ),
-                                        'href'   => trailingslashit( $profile_link . 'change-avatar' )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-change-avatar',
+                                        'title'    => _x( 'Change Profile Photo', 'My Account Profile sub nav', 'buddypress' ),
+                                        'href'     => trailingslashit( $profile_link . 'change-avatar' ),
+                                        'position' => 30
                                 );
                         }
@@ -345 +348 @@
                         if ( bp_displayed_user_use_cover_image_header() ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-change-cover-image',
-                                        'title'  => _x( 'Change Cover Image', 'My Account Profile sub nav', 'buddypress' ),
-                                        'href'   => trailingslashit( $profile_link . 'change-cover-image' )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-change-cover-image',
+                                        'title'    => _x( 'Change Cover Image', 'My Account Profile sub nav', 'buddypress' ),
+                                        'href'     => trailingslashit( $profile_link . 'change-cover-image' ),
+                                        'position' => 40
                                 );
                         }