Changeset 10555 for trunk/src/bp-notifications/classes/class-bp-notifications-component.php

Timestamp:

02/08/2016 05:56:22 AM (9 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-component.php (modified) (1 diff)

trunk/src/bp-notifications/classes/class-bp-notifications-component.php

@@ -203 +203 @@
             // Unread.
             $wp_admin_nav[] = array(
-                'parent' => 'my-account-' . $this->id,
-                'id'     => 'my-account-' . $this->id . '-unread',
-                'title'  => $unread,
-                'href'   => $notifications_link
+                'parent'   => 'my-account-' . $this->id,
+                'id'       => 'my-account-' . $this->id . '-unread',
+                'title'    => $unread,
+                'href'     => $notifications_link,
+                'position' => 10
             );
 
             // Read.
             $wp_admin_nav[] = array(
-                'parent' => 'my-account-' . $this->id,
-                'id'     => 'my-account-' . $this->id . '-read',
-                'title'  => _x( 'Read', 'My Account Notification sub nav', 'buddypress' ),
-                'href'   => trailingslashit( $notifications_link . 'read' ),
+                'parent'   => 'my-account-' . $this->id,
+                'id'       => 'my-account-' . $this->id . '-read',
+                'title'    => _x( 'Read', 'My Account Notification sub nav', 'buddypress' ),
+                'href'     => trailingslashit( $notifications_link . 'read' ),
+                'position' => 20
             );
         }