Changeset 10555 for trunk/src/bp-messages/classes/class-bp-messages-component.php

Timestamp:

02/08/2016 05:56:22 AM (11 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-messages/classes/class-bp-messages-component.php (modified) (4 diffs)

trunk/src/bp-messages/classes/class-bp-messages-component.php

@@ -254 +254 @@
                         // Inbox.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-inbox',
-                                'title'  => $inbox,
-                                'href'   => $messages_link
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-inbox',
+                                'title'    => $inbox,
+                                'href'     => $messages_link,
+                                'position' => 10
                         );
 
@@ -263 +264 @@
                         if ( bp_is_active( $this->id, 'star' ) ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-starred',
-                                        'title'  => __( 'Starred', 'buddypress' ),
-                                        'href'   => trailingslashit( $messages_link . bp_get_messages_starred_slug() )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-starred',
+                                        'title'    => __( 'Starred', 'buddypress' ),
+                                        'href'     => trailingslashit( $messages_link . bp_get_messages_starred_slug() ),
+                                        'position' => 11
                                 );
                         }
@@ -272 +274 @@
                         // Sent Messages.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-sentbox',
-                                'title'  => __( 'Sent', 'buddypress' ),
-                                'href'   => trailingslashit( $messages_link . 'sentbox' )
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-sentbox',
+                                'title'    => __( 'Sent', 'buddypress' ),
+                                'href'     => trailingslashit( $messages_link . 'sentbox' ),
+                                'position' => 20
                         );
 
                         // Compose Message.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-compose',
-                                'title'  => __( 'Compose', 'buddypress' ),
-                                'href'   => trailingslashit( $messages_link . 'compose' )
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-compose',
+                                'title'    => __( 'Compose', 'buddypress' ),
+                                'href'     => trailingslashit( $messages_link . 'compose' ),
+                                'position' => 30
                         );
 
@@ -289 +293 @@
                         if ( bp_current_user_can( 'bp_moderate' ) ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-notices',
-                                        'title'  => __( 'All Member Notices', 'buddypress' ),
-                                        'href'   => trailingslashit( $messages_link . 'notices' )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-notices',
+                                        'title'    => __( 'All Member Notices', 'buddypress' ),
+                                        'href'     => trailingslashit( $messages_link . 'notices' ),
+                                        'position' => 90
                                 );
                         }