Changeset 10555 for trunk/src/bp-core/classes/class-bp-component.php

Timestamp:

02/08/2016 05:56:22 AM (11 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-core/classes/class-bp-component.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-component.php

@@ -549 +549 @@
                 // Do we have Toolbar menus to add?
                 if ( !empty( $wp_admin_nav ) ) {
+                        // Fill in position if one wasn't passed for backpat.
+                        $pos = 0;
+                        $not_set_pos = 1;
+                        foreach( $wp_admin_nav as $key => $nav ) {
+                                if ( ! isset( $nav['position'] ) ) {
+                                        $wp_admin_nav[$key]['position'] = $pos + $not_set_pos;
+
+                                        if ( 9 !== $not_set_pos ) {
+                                                ++$not_set_pos;
+                                        }
+                                } else {
+                                        $pos = $nav['position'];
+
+                                        // Reset not set pos to 1
+                                        if ( $pos % 10 === 0 ) {
+                                                $not_set_pos = 1;
+                                        }
+                                }
+                        }
+
+                        // Sort admin nav by position.
+                        $wp_admin_nav = bp_sort_by_key( $wp_admin_nav, 'position', 'num' );
 
                         // Set this objects menus.