Changeset 10555 for trunk/src/bp-activity/classes/class-bp-activity-component.php

Timestamp:

02/08/2016 05:56:22 AM (10 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-activity/classes/class-bp-activity-component.php (modified) (5 diffs)

trunk/src/bp-activity/classes/class-bp-activity-component.php

@@ -277 +277 @@
             // Personal.
             $wp_admin_nav[] = array(
-                'parent' => 'my-account-' . $this->id,
-                'id'     => 'my-account-' . $this->id . '-personal',
-                'title'  => _x( 'Personal', 'My Account Activity sub nav', 'buddypress' ),
-                'href'   => $activity_link
+                'parent'   => 'my-account-' . $this->id,
+                'id'       => 'my-account-' . $this->id . '-personal',
+                'title'    => _x( 'Personal', 'My Account Activity sub nav', 'buddypress' ),
+                'href'     => $activity_link,
+                'position' => 10
             );
 
@@ -286 +287 @@
             if ( bp_activity_do_mentions() ) {
                 $wp_admin_nav[] = array(
-                    'parent' => 'my-account-' . $this->id,
-                    'id'     => 'my-account-' . $this->id . '-mentions',
-                    'title'  => $title,
-                    'href'   => trailingslashit( $activity_link . 'mentions' )
+                    'parent'   => 'my-account-' . $this->id,
+                    'id'       => 'my-account-' . $this->id . '-mentions',
+                    'title'    => $title,
+                    'href'     => trailingslashit( $activity_link . 'mentions' ),
+                    'position' => 20
                 );
             }
@@ -296 +298 @@
             if ( bp_activity_can_favorite() ) {
                 $wp_admin_nav[] = array(
-                    'parent' => 'my-account-' . $this->id,
-                    'id'     => 'my-account-' . $this->id . '-favorites',
-                    'title'  => _x( 'Favorites', 'My Account Activity sub nav', 'buddypress' ),
-                    'href'   => trailingslashit( $activity_link . 'favorites' )
+                    'parent'   => 'my-account-' . $this->id,
+                    'id'       => 'my-account-' . $this->id . '-favorites',
+                    'title'    => _x( 'Favorites', 'My Account Activity sub nav', 'buddypress' ),
+                    'href'     => trailingslashit( $activity_link . 'favorites' ),
+                    'position' => 30
                 );
             }
@@ -306 +309 @@
             if ( bp_is_active( 'friends' ) ) {
                 $wp_admin_nav[] = array(
-                    'parent' => 'my-account-' . $this->id,
-                    'id'     => 'my-account-' . $this->id . '-friends',
-                    'title'  => _x( 'Friends', 'My Account Activity sub nav', 'buddypress' ),
-                    'href'   => trailingslashit( $activity_link . bp_get_friends_slug() )
+                    'parent'   => 'my-account-' . $this->id,
+                    'id'       => 'my-account-' . $this->id . '-friends',
+                    'title'    => _x( 'Friends', 'My Account Activity sub nav', 'buddypress' ),
+                    'href'     => trailingslashit( $activity_link . bp_get_friends_slug() ),
+                    'position' => 40
                 );
             }
@@ -316 +320 @@
             if ( bp_is_active( 'groups' ) ) {
                 $wp_admin_nav[] = array(
-                    'parent' => 'my-account-' . $this->id,
-                    'id'     => 'my-account-' . $this->id . '-groups',
-                    'title'  => _x( 'Groups', 'My Account Activity sub nav', 'buddypress' ),
-                    'href'   => trailingslashit( $activity_link . bp_get_groups_slug() )
+                    'parent'   => 'my-account-' . $this->id,
+                    'id'       => 'my-account-' . $this->id . '-groups',
+                    'title'    => _x( 'Groups', 'My Account Activity sub nav', 'buddypress' ),
+                    'href'     => trailingslashit( $activity_link . bp_get_groups_slug() ),
+                    'position' => 50
                 );
             }