Changeset 10553 for trunk/src/bp-members/classes/class-bp-core-members-widget.php

Timestamp:

02/08/2016 04:14:59 AM (10 years ago)

Author:

boonebgorges

Message:

Restore template globals after widget loops.

BP template loop functions, like bp_has_members(), are responsible for
populating corresponding template globals. When this happens inside of a
"secondary" loop - such as a sidebar widget - the loop should clean up after
itself by resetting the relevant template global to whatever it previously was
before the secondary loop had run. (This is a rough approximation of WP's
wp_reset_postdata() for BP loops.)

Fixes #5170.

File:

• trunk/src/bp-members/classes/class-bp-core-members-widget.php (modified) (3 diffs)

trunk/src/bp-members/classes/class-bp-core-members-widget.php

@@ -48 +48 @@
          */
         public function widget( $args, $instance ) {
+                global $members_template;
 
                 // Get widget settings.
@@ -88 +89 @@
                         'populate_extras' => true,
                         'search_terms'    => false,
-                ); ?>
+                );
+
+                // Back up the global.
+                $old_members_template = $members_template;
+
+                ?>
 
                 <?php if ( bp_has_members( $members_args ) ) : ?>
@@ -146 +152 @@
 
                 <?php echo $args['after_widget'];
+
+                // Restore the global.
+                $members_template = $old_members_template;
         }