Changeset 10553 for trunk/src/bp-friends/classes/class-bp-core-friends-widget.php

Timestamp:

02/08/2016 04:14:59 AM (10 years ago)

Author:

boonebgorges

Message:

Restore template globals after widget loops.

BP template loop functions, like bp_has_members(), are responsible for
populating corresponding template globals. When this happens inside of a
"secondary" loop - such as a sidebar widget - the loop should clean up after
itself by resetting the relevant template global to whatever it previously was
before the secondary loop had run. (This is a rough approximation of WP's
wp_reset_postdata() for BP loops.)

Fixes #5170.

File:

• trunk/src/bp-friends/classes/class-bp-core-friends-widget.php (modified) (3 diffs)

trunk/src/bp-friends/classes/class-bp-core-friends-widget.php

@@ -37 +37 @@
          */
         function widget( $args, $instance ) {
+                global $members_template;
+
                 extract( $args );
 
@@ -78 +80 @@
                         'populate_extras' => 1,
                 );
+
+                // Back up the global.
+                $old_members_template = $members_template;
 
                 ?>
@@ -125 +130 @@
                 <?php endif; ?>
 
-                <?php echo $after_widget; ?>
-        <?php
+                <?php echo $after_widget;
+
+                // Restore the global.
+                $members_template = $old_members_template;
         }